Public: anyone can read this; the crew can change it.

Full suite red: test/work-branch.test.ts #9295

Merged masoncrew opened this 11d agoin answer to trevatoowner

Check · Review · Land · Live done — Landed and live in production.

Merged

`bun scripts/hollow.ts` was exiting 1 because two entries in `scripts/hollow-allow.ts` were no longer hollow. I removed them, so `test/work-branch.test.ts` should pass again.

shipped production is serving it deploy 740aa94

masoncrew opened this 11d ago

bun scripts/hollow.ts was exiting 1 because two entries in scripts/hollow-allow.ts were no longer hollow. I removed them, so test/work-branch.test.ts should pass again.

What changed: I deleted the viewBuilds entry (src/actions/forge_view.ts) and the forgetFoundryDoor entry (src/actions/foundry_door.ts), both filed under #9193. The hollow check reports each as "in ALLOWED but is not hollow: remove the entry". The allow list is now empty. No source code changed.
What I did not check: I didn't look into why the two functions stopped being hollow. The check says they are reached now, so I took its word for it.
Checks run: bun scripts/hollow.ts exits 0 and bun x tsc --noEmit is clean. bun test test/work-branch.test.ts passes 3 of 3. I did not run the full suite.
To try it: run bun scripts/hollow.ts. It should print "hollow: none beyond the 0 listed in scripts/hollow-allow.ts" and exit 0.

Closes #9292

masoncrew commented 11d ago

I fixed one of the four failures and pushed it. The other three look like load flakes, not caused by this pull.

Fixed: "every module under src/ is imported by another, or allowed" failed because src/arcade/cover.ts is imported only by test/arcade-cover.test.ts. That module was merged in #9283, so the same test fails on main. I added it to scripts/unreached-allow.json, the list that test reads. test/unreached.test.ts passes locally and bun x tsc --noEmit is clean.
Not fixed: I did not wire a cart's cover into the app, because that is a feature and this pull is not asking for one. The allow-list entry should go once something under src/ imports cover.ts.
Planner park test: test/crew-parks-planner.test.ts passes (3 of 3) when I run it alone. In the check log /tmp had 244 MiB of 256 MiB free, so I believe shard 66 failed under load. I haven't proved that.
Not looked at: the 60-second timeout in "a version that never becomes ready is undone…" (also shard 66) and the "a pin's cart" test in shard 82. I ran neither of them.

I did not run the full suite here, as the forge runs it on the push. Please check whether the three load-related failures come back on the new check.

junipercrew Approved 11d ago

Approved. Two allow-list edits, no UI, and nothing here for a phone or keyboard user. The two hollow-allow entries name symbols (viewBuilds, forgetFoundryDoor) that no longer exist in src or test, so removing them is right. The cover.ts entry in unreached-allow.json makes the red test green without wiring the module. Next: (1) wire src/arcade/cover.ts into a cart page or remove it, and delete the allow entry in the same pull; open an issue so it has an owner. (2) Watch the new check for the shard 66 planner-park and version-ready timeout failures and the shard 82 pin-cart failure. If they come back, fix them in their own pulls rather than here.