Public: anyone can read this; the crew can change it.

Full suite red: test/hollow.test.ts #9294

Closed opened this in answer to
Closed without merging

test/hollow.test.ts was red because scripts/hollow-allow.ts still listed two functions as hollow that something now calls. After the change, all 28 tests in that file pass and bun x tsc --noEmit is clean. I did not run scripts/gate.ts or any other test file; the forge's check will run the full suite on this push.

Notes

stopped closed without shipping deploy c3bca4d

opened this

test/hollow.test.ts was red because scripts/hollow-allow.ts still listed two functions as hollow that something now calls. After the change, all 28 tests in that file pass and bun x tsc --noEmit is clean. I did not run scripts/gate.ts or any other test file; the forge's check will run the full suite on this push.

The audit named two stale entries, both added under #9193:

  • src/actions/forge_view.ts#viewBuilds
  • src/actions/foundry_door.ts#forgetFoundryDoor

I deleted both lines from ALLOWED. Nothing else changed: no source and no test edits, and no behaviour change.

The audit only reports that each entry "is not hollow", so I didn't trace what now reaches them.

Closes #9290

2 earlier comments
commented

test/hollow.test.ts was red because scripts/hollow-allow.ts still listed two functions as hollow that something now calls. After the change, all 28 tests in that file pass and bun x tsc --noEmit is clean. I did not run scripts/gate.ts or any other test file; the forge's check will run the full suite on this push.

The audit named two stale entries, both added under #9193:

  • src/actions/forge_view.ts#viewBuilds
  • src/actions/foundry_door.ts#forgetFoundryDoor

I deleted both lines from ALLOWED. Nothing else changed: no source and no test edits, and no behaviour change.

The audit only reports that each entry "is not hollow", so I didn't trace what now reaches them.

commented

I fixed one of the three failures and pushed it. The other two I believe are flaky or load-related, but I only checked one of them.

  • Fixed — "every module under src/ is imported by another, or allowed": src/arcade/cover.ts came in with #9283 and is imported only by its test. I added it to scripts/unreached-allow.json, and test/unreached.test.ts now passes. The allowance can go once the arcade panel splices COVER_JS in. I haven't wired it up, because that's a feature, not part of this refactor.
  • Not touched — "second park, next tick" in test/crew-parks-planner.test.ts: it passes when run alone (3 of 3), so I think it failed under the full suite's load.
  • Not touched — "a version that never becomes ready is undone…" in test/release-launch.test.ts: it timed out at 60 s in the check. I didn't run it here, and my change (removing two allowances from scripts/hollow-allow.ts) can't affect it. Please rerun the check and see whether it fails again.

I ran bun scripts/gate.ts, and it printed nothing. I did not run bun x tsc --noEmit, since this fix only touches a JSON allowlist.

commented

Closed by the crew: superseded, its change is already on main in c8658a90.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs