Public: anyone can read this; the crew can change it.
Full suite red: test/hollow-cli.test.ts #9263
bun scripts/hollow.ts was exiting 1 on main, which is why test/hollow-cli.test.ts went red. After this change it prints hollow: none beyond the 2 listed in scripts/hollow-allow.ts and exits 0.
stopped closed without shipping deploy 5177b4a
2 earlier comments
bun scripts/hollow.ts was exiting 1 on main, which is why test/hollow-cli.test.ts went red. After this change it prints hollow: none beyond the 2 listed in scripts/hollow-allow.ts and exits 0.
The audit flagged two exports that #9193 added to src/actions/ and that only tests call:
forge_view.ts#viewBuildsis a counter that the view's cost tests read.foundry_door.ts#forgetFoundryDooris a reset that the door's tests call between cases.
I listed both in scripts/hollow-allow.ts, each with its reason and #9260 as the owning issue. No source or test file changed.
Decision for you: the allowlist is meant to shrink, and a test-only seam is exactly what it exists to catch. The alternative is to move those two helpers out of src/actions/ into a test helper. I judged that a bigger change than a red-suite fix needs. If you'd rather have it, say so and I'll do it in a follow-up.
bun scripts/hollow.ts, bun scripts/gate.ts, bun x tsc --noEmit and test/hollow-cli.test.ts plus test/hollow.test.ts (29 tests) all pass here. I did not run the full suite; the forge's check does that on push.
To try it, run bun scripts/hollow.ts.
I merged main into the branch and pushed. The only conflict was in scripts/hollow-allow.ts.
main now lists the same two test-only seams, viewBuilds and forgetFoundryDoor, under #9193. I took main's version of the file, so the branch now differs from main only by the merge commit, with no content change. That means #9263 no longer fixes anything by itself: main already carries the fix for the red suite, and you may want to close the pull.
After the merge, bun scripts/hollow.ts prints hollow: none beyond the 2 listed in scripts/hollow-allow.ts. bun x tsc --noEmit is clean, and test/hollow-cli.test.ts plus test/hollow.test.ts pass (29 tests). I did not run the full suite or bun scripts/gate.ts this time.
Closed by the crew: superseded, its change is already on main in 55f04052.
bun scripts/hollow.tswas exiting 1 on main, which is whytest/hollow-cli.test.tswent red. After this change it printshollow: none beyond the 2 listed in scripts/hollow-allow.tsand exits 0.The audit flagged two exports that #9193 added to
src/actions/and that only tests call:forge_view.ts#viewBuildsis a counter that the view's cost tests read.foundry_door.ts#forgetFoundryDooris a reset that the door's tests call between cases.I listed both in
scripts/hollow-allow.ts, each with its reason and #9260 as the owning issue. No source or test file changed.Decision for you: the allowlist is meant to shrink, and a test-only seam is exactly what it exists to catch. The alternative is to move those two helpers out of
src/actions/into a test helper. I judged that a bigger change than a red-suite fix needs. If you'd rather have it, say so and I'll do it in a follow-up.bun scripts/hollow.ts,bun scripts/gate.ts,bun x tsc --noEmitandtest/hollow-cli.test.tsplustest/hollow.test.ts(29 tests) all pass here. I did not run the full suite; the forge's check does that on push.To try it, run
bun scripts/hollow.ts.Closes #9260