Public: anyone can read this; the crew can change it.
Each look records whether its page scrolls sideways and how many screens tall it is, and the pull's looks name any phone page that scrolls sideways #9256
Each look now records its page's size, and a phone page that scrolls sideways is named in one plain line. The last checklist item, the #9240 comment, is not done. The bun test runs I did here were test/looks.test.ts and test/check-vitals.test.ts.
stopped parked by the crew deploy 847a5ca
3 earlier comments
Each look now records its page's size, and a phone page that scrolls sideways is named in one plain line. The last checklist item, the #9240 comment, is not done.
The bun test runs I did here were test/looks.test.ts and test/check-vitals.test.ts. Three tests in test/looks.test.ts fail the same way without my change, because the sandbox's Chromium can't open its socket. They are the real-browser tests: the capture through the grant door, the browser error page, and the dark capture. bun x tsc --noEmit, scripts/gate.ts and scripts/design-lint.ts came back clean. I did not run the whole suite.
What changed
- Recording: the same DevTools read after load now also returns
scrollWidth,scrollHeight,innerWidthandinnerHeight. There is no extra navigation or browser start. - Parsing:
parseRecordedkeeps those four only as whole non-negative numbers. A missing or malformed one is left out rather than failing the look. - Storage: each look's entry in the check's vitals file now carries
sidewaysandscreens, beside its LCP and layout shift.sidewaysisscrollWidth > innerWidth.screensisscrollHeight / innerHeight, rounded to one decimal. Either is absent when its inputs weren't given. I read "stored with" as the vitals file, since that is where LCP and layout shift live. The picture rows in the database are unchanged. - Notice: a phone look that scrolls sideways produces
<page> scrolls sideways at phone width, for example/preview-admin/sample/held scrolls sideways at phone width. It shows in the check's vitals line and above the vitals table on the run page. A page that fits, or a desktop look, says nothing, and there is no banner or colour. - Tests: they cover
parseRecordedwith the fields present, missing and malformed, and the storedsidewaysandscreenson a look that went through the service. They also cover the notice appearing for a sideways phone look and not otherwise, in both the line and the table.
Beyond the listed files
The notice needed a place to show, so I also touched src/checks/summary.ts, src/checks/looks.ts, src/checks/progress.ts and src/web/studio/vitals.ts. src/http/api.ts is untouched.
Not done
- #9240 comment: the held and bets phone
screenshave to come from this pull's own preview, which didn't exist when I pushed. I also couldn't read the looks from here. Someone needs to read them once the preview has taken its looks and post them on #9240. - Other surfaces: the notice is not on the pull page's picture list or in the MCP and API
pullLooksoutput, since those list pictures, not vitals.
I fixed the failed check by adding a commit whose message has the required Try: line, and pushed it. The gate rule was about the commit message, not the code, so nothing else changed. I haven't seen the forge's check re-run on the push.
The local gate printed nothing when I ran it just now, so I'm taking that as passing, though I didn't see an explicit pass message. The tests and type check passed earlier and the code is unchanged. The same three real-browser tests still fail in this sandbox, as before.
The Try: line says: open the pull's latest check run page on the preview and read above the vitals table for a "<page> scrolls sideways at phone width" line.
The #9240 comment with the held and bets phone screens is still not posted. I couldn't read the looks from this sandbox, so someone needs to take them from the preview and post them.
I haven't fixed this one. I think the memory stop wasn't caused by my change, so I pushed an empty commit to re-run the check.
The log shows 235 tests passing with 0 failures. The check was then stopped at 8718 MiB, over the 8192 MiB limit, while starting shard 15 of 63. Those shards are test files my change doesn't touch. My diff is about 140 lines of small parsing and string code and can't plausibly use gigabytes. I did not reproduce the memory use, so this is my read, not something I've confirmed.
If the re-run stops on memory again, the cause is probably the machine's load or the shard sizing, and a person should look at that rather than at this pull.
Parked by the crew: the check stayed red through 2 automatic tries
Each look now records its page's size, and a phone page that scrolls sideways is named in one plain line. The last checklist item, the #9240 comment, is not done.
The
bun testruns I did here weretest/looks.test.tsandtest/check-vitals.test.ts. Three tests intest/looks.test.tsfail the same way without my change, because the sandbox's Chromium can't open its socket. They are the real-browser tests: the capture through the grant door, the browser error page, and the dark capture.bun x tsc --noEmit,scripts/gate.tsandscripts/design-lint.tscame back clean. I did not run the whole suite.What changed
scrollWidth,scrollHeight,innerWidthandinnerHeight. There is no extra navigation or browser start.parseRecordedkeeps those four only as whole non-negative numbers. A missing or malformed one is left out rather than failing the look.sidewaysandscreens, beside its LCP and layout shift.sidewaysisscrollWidth > innerWidth.screensisscrollHeight / innerHeight, rounded to one decimal. Either is absent when its inputs weren't given. I read "stored with" as the vitals file, since that is where LCP and layout shift live. The picture rows in the database are unchanged.<page> scrolls sideways at phone width, for example/preview-admin/sample/held scrolls sideways at phone width. It shows in the check's vitals line and above the vitals table on the run page. A page that fits, or a desktop look, says nothing, and there is no banner or colour.parseRecordedwith the fields present, missing and malformed, and the storedsidewaysandscreenson a look that went through the service. They also cover the notice appearing for a sideways phone look and not otherwise, in both the line and the table.Beyond the listed files The notice needed a place to show, so I also touched
src/checks/summary.ts,src/checks/looks.ts,src/checks/progress.tsandsrc/web/studio/vitals.ts.src/http/api.tsis untouched.Not done
screenshave to come from this pull's own preview, which didn't exist when I pushed. I also couldn't read the looks from here. Someone needs to read them once the preview has taken its looks and post them on #9240.pullLooksoutput, since those list pictures, not vitals.Closes #9249