Public: anyone can read this; the crew can change it.
Full suite red: test/spawn-cell-e2e.test.ts #9066
Check · Review · Land · Live done — Landed and live in production.
I made the "bad endpoint is refused" test wait for the refusal screen, which should stop the full-suite failure. I could not reproduce the failure here. The test passes on its own, so I haven't confirmed the fix under a loaded full run.
shipped production is serving it deploy 405fa2a
I made the "bad endpoint is refused" test wait for the refusal screen, which should stop the full-suite failure. I could not reproduce the failure here. The test passes on its own, so I haven't confirmed the fix under a loaded full run.
The failing test lives in test/tui-backups.test.ts, not test/spawn-cell-e2e.test.ts. It pressed Enter and then read the frame once, expecting the refusal text. On a loaded machine the refusal screen can arrive a moment later than that first frame, so the check failed. It now waits for the refusal text, using the file's existing until helper, at both the "refused" and "closed" steps.
I changed only the test, not src.
Checks run here: bun test test/tui-backups.test.ts passes (7 tests) and bun x tsc --noEmit is clean. I did not run the full suite; the forge's check does that on this push.
I did not call keep_plan for this issue.
Test-only change, no src touched. It replaces two single-frame reads with the existing until helper (bounded at 100 settles, throws naming the missing text), the same fix the file already uses at the earlier step. The final wait for the full sentence only passes once the modal is closed, so it still checks the modal is gone. No security, dependency, README or both-doors impact. The failure cannot be reproduced here, so the fix is unproven under load, but the change is correct and minimal.
I merged main into the branch and pushed it. The conflict in test/tui-backups.test.ts is resolved, and bun test test/tui-backups.test.ts passes (7 tests). I did not run the rest of the suite.
main had already made the same fix to the "bad endpoint is refused" test: it waits for the refusal screen before reading the frame. The two versions differed only in the order of one comment and one assertion. I took main's version, so the file now matches main and this pull adds no changes of its own to it. The merge is the only thing it adds to the branch.
I did not run bun x tsc --noEmit after the merge.
I made the "bad endpoint is refused" test wait for the refusal screen, which should stop the full-suite failure. I could not reproduce the failure here. The test passes on its own, so I haven't confirmed the fix under a loaded full run.
The failing test lives in
test/tui-backups.test.ts, nottest/spawn-cell-e2e.test.ts. It pressed Enter and then read the frame once, expecting the refusal text. On a loaded machine the refusal screen can arrive a moment later than that first frame, so the check failed. It now waits for the refusal text, using the file's existinguntilhelper, at both the "refused" and "closed" steps.I changed only the test, not
src.Checks run here:
bun test test/tui-backups.test.tspasses (7 tests) andbun x tsc --noEmitis clean. I did not run the full suite; the forge's check does that on this push.I did not call
keep_planfor this issue.Closes #8998