Public: anyone can read this; the crew can change it.

The preview seed holds a wave and a milestone, so the Story pages are seen filled on every preview #8884

Parked opened this
Closed without merging

The preview seed now gives the sample repository one wave and one milestone, so the Story pages show data on a preview. The three test files I ran pass, as do tsc and scripts/gate.ts; I did not run the rest of the suite or scripts/design-lint.ts. keepplan wasn't among my tools, so the issue has no plan.

Notes

stopped parked by the crew deploy f056834

opened this

The preview seed now gives the sample repository one wave and one milestone, so the Story pages show data on a preview. The three test files I ran pass, as do tsc and scripts/gate.ts; I did not run the rest of the suite or scripts/design-lint.ts. keep_plan wasn't among my tools, so the issue has no plan.

  • Wave: the first commit on sample now carries waves/0.1.0.md, headline "A greeting lands", with three highlights. It links to the seeded pull #3, so /waves shows "1 pull". It's built with writeWave, so it can't drift from the format.
  • Milestone: "Say hello everywhere" is an issue that waits for the two first seeded issues, and one of those is closed as done. /milestones reads "1 of 2 done".
  • Looks: forge.json adds /preview-admin/sample/waves and /preview-admin/sample/milestones to both app.looks and app.looksAsOwner.
  • Tests: test/looks-owner.test.ts fetches both pages as the preview admin. It checks that forge.json lists them in app.looks and app.looksAsOwner. It also checks that the wave's headline and "1 pull" appear, and that the milestone's name and "1 of 2 done" appear. The seed's issue count in that file goes from 11 to 12.
  • Cap raised from 24 to 26: the two new looks took the list to 26 paths, over the app.looks limit of 24. The router's top-level pages must all be listed, so I couldn't drop any. I raised LOOKS_MAX in src/apps/manifest.ts to 26 and updated docs/APPS.md, test/forge-looks.test.ts and test/apps-adversarial.test.ts to match. Each look costs a browser start per width, so that cost goes up a little; say if you'd rather trim a page than raise the cap.

I left out a second wave, an unbacked milestone and any seeded spend on the milestone. /waves and /milestones for the seeded repository are what to open on a preview.

🤖 Generated with Claude Code

Closes #8868

3 earlier comments · 1 event
commented

The preview seed now gives the sample repository one wave and one milestone, so the Story pages show data on a preview. The three test files I ran pass, as do tsc and scripts/gate.ts; I did not run the rest of the suite or scripts/design-lint.ts. keep_plan wasn't among my tools, so the issue has no plan.

  • Wave: the first commit on sample now carries waves/0.1.0.md, headline "A greeting lands", with three highlights. It links to the seeded pull #3, so /waves shows "1 pull". It's built with writeWave, so it can't drift from the format.
  • Milestone: "Say hello everywhere" is an issue that waits for the two first seeded issues, and one of those is closed as done. /milestones reads "1 of 2 done".
  • Looks: forge.json adds /preview-admin/sample/waves and /preview-admin/sample/milestones to both app.looks and app.looksAsOwner.
  • Tests: test/looks-owner.test.ts fetches both pages as the preview admin. It checks that forge.json lists them in app.looks and app.looksAsOwner. It also checks that the wave's headline and "1 pull" appear, and that the milestone's name and "1 of 2 done" appear. The seed's issue count in that file goes from 11 to 12.
  • Cap raised from 24 to 26: the two new looks took the list to 26 paths, over the app.looks limit of 24. The router's top-level pages must all be listed, so I couldn't drop any. I raised LOOKS_MAX in src/apps/manifest.ts to 26 and updated docs/APPS.md, test/forge-looks.test.ts and test/apps-adversarial.test.ts to match. Each look costs a browser start per width, so that cost goes up a little; say if you'd rather trim a page than raise the cap.

I left out a second wave, an unbacked milestone and any seeded spend on the milestone. /waves and /milestones for the seeded repository are what to open on a preview.

🤖 Generated with Claude Code

commented

I couldn't see why the check failed: the log you sent ends right after the install step. I merged the current main into the branch and pushed it, but the forge's check hasn't re-run on that push, so I can't say it's green.

After the merge, bun scripts/gate.ts and bun x tsc --noEmit are clean. scripts/fast.ts exited 2 (forge.json changed, so the diff is too broad to name). I ran 60 test files that mention forge.json, the preview seed, app.looks or parseManifest: 577 pass, 0 fail. I did not run the rest of the suite.

The change itself is as in the earlier description. The preview seed writes a wave (waves/0.1.0.md) that names pull #3, and a milestone that two seeded issues hold up, with one of them closed so it reads "1 of 2 done". forge.json lists /waves and /milestones in both app.looks and app.looksAsOwner, and the look cap went from 24 to 26 to fit them. test/looks-owner.test.ts renders both pages as the preview admin and checks the wave's headline and the milestone's progress.

If the check fails again, send me the end of the log from the failing step, since the part you sent stops before it.

🤖 Generated with Claude Code

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

The preview seed now has a sample wave and a sample milestone, with pages for each. This push fixes the merge conflict in forge.json that failed the check. The forge's check has not run on the new push yet.

  • The conflict: main had added /system and /resilience to looksAsOwner, and my branch had added the wave and milestone pages to both look lists.
  • The resolution: looks has the wave and milestone pages, and looksAsOwner has them plus /system and /resilience.
  • What I ran: the gate and tsc --noEmit came back clean. test/looks-owner.test.ts passes (17 tests). I did not run the full suite, since the forge's check does that on push.

To try it, open /preview-admin/sample/waves and /preview-admin/sample/milestones on the preview.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs