The pull page shows less at rest, and every action it had stays one step away #8803

The pull page now shows less at rest, and every action it had is still on the page or in Cmd-K. The page's HTML went from 31,968 to 31,013 bytes on the snappy fixture (open pull, owner's view); the byte budget in test/pull-quiet.test.ts is tightened to 31,100.

What changed

• State: the state badge in the head is now a dot with an aria-label and no title. Merged, Closed and Parked are also written beside the dot.
• Check line: the check is one muted line with a dot and its note. The card around it is gone, and the word is written out when someone is needed.
• Path line: the "Next: …" line is folded into the path paragraph, and the per-step tooltips are dropped.
• Decision: the Decide card is now a plain block (id="decide") holding the one primary action.
• Hold: Hold is now just the form, folded under a "More" disclosure below the conversation. A hold that is already set still shows as its own card.
• Take it back: Take it back now sits under the same "More".
• Palette: a new pullActions (src/web/studio/change.ts) puts these in the palette: Conversation, Files, Ship (or Bring up to date when the branch conflicts), Check again, Hold, Comment, Close pull request, Edit and Take it back. Each appears only where the viewer may use it.
• Header: the where strip (and its "keep on my machine" pin) no longer appears on a pull's page. It stays on the repository's home, and the palette has a "Where it is read from" row for it. I added a quiet option to repoHeader for this.
• Docs: docs/design/areas/pull.md says in one line what the page is for. bun scripts/design-lint.ts and the gate are clean, and tsc is clean.

Tests

• test/pull-quiet.test.ts checks the byte budget and the dot, that every action is still on the page, and that each is in the palette. A unit test covers who is offered what.
• I wrote it against main's page, but it was never run there: it fails to compile until pullActions exists, so the "nothing dropped" guard is untested against the old page.
• I changed three existing test files because they asserted the old markup. test/holds.test.ts now expects id="hold" instead of the "Hold this pull request" summary. test/studio-shipping.test.ts now expects id="decide" instead of <h2>Decide</h2>.
• I ran about 80 pull, hold, ship and palette test files and test/issues-quiet.test.ts. After one fix (the merged-state word), they pass.
• I did not run the full suite; the forge's check does that.

Left out

• Screenshots: the sandbox can't take desk and phone screenshots, so none are attached. Someone needs to add them from the preview.
• Savings: the HTML saving is small (about 3%) because the shared repo header and the thread composer are the bulk of the page. I left both alone because other pages use them.
• Visual check: nothing was checked visually (no screenshots), and no new CSS was added.

Try it: open any pull on the preview. You get the dot, one check line, Ship if it's yours to ship, and "More" under the comment box. Cmd-K then "#N" lists every action.

Closes #8773

The pull page now shows less at rest, and every action it had is still on the page or in Cmd-K. The page's HTML went from 31,968 to 31,013 bytes on the snappy fixture (open pull, owner's view); the byte budget in test/pull-quiet.test.ts is tightened to 31,100.

What changed

• State: the state badge in the head is now a dot with an aria-label and no title. Merged, Closed and Parked are also written beside the dot.
• Check line: the check is one muted line with a dot and its note. The card around it is gone, and the word is written out when someone is needed.
• Path line: the "Next: …" line is folded into the path paragraph, and the per-step tooltips are dropped.
• Decision: the Decide card is now a plain block (id="decide") holding the one primary action.
• Hold: Hold is now just the form, folded under a "More" disclosure below the conversation. A hold that is already set still shows as its own card.
• Take it back: Take it back now sits under the same "More".
• Palette: a new pullActions (src/web/studio/change.ts) puts these in the palette: Conversation, Files, Ship (or Bring up to date when the branch conflicts), Check again, Hold, Comment, Close pull request, Edit and Take it back. Each appears only where the viewer may use it.
• Header: the where strip (and its "keep on my machine" pin) no longer appears on a pull's page. It stays on the repository's home, and the palette has a "Where it is read from" row for it. I added a quiet option to repoHeader for this.
• Docs: docs/design/areas/pull.md says in one line what the page is for. bun scripts/design-lint.ts and the gate are clean, and tsc is clean.

Tests

• test/pull-quiet.test.ts checks the byte budget and the dot, that every action is still on the page, and that each is in the palette. A unit test covers who is offered what.
• I wrote it against main's page, but it was never run there: it fails to compile until pullActions exists, so the "nothing dropped" guard is untested against the old page.
• I changed three existing test files because they asserted the old markup. test/holds.test.ts now expects id="hold" instead of the "Hold this pull request" summary. test/studio-shipping.test.ts now expects id="decide" instead of <h2>Decide</h2>.
• I ran about 80 pull, hold, ship and palette test files and test/issues-quiet.test.ts. After one fix (the merged-state word), they pass.
• I did not run the full suite; the forge's check does that.

Left out

• Screenshots: the sandbox can't take desk and phone screenshots, so none are attached. Someone needs to add them from the preview.
• Savings: the HTML saving is small (about 3%) because the shared repo header and the thread composer are the bulk of the page. I left both alone because other pages use them.
• Visual check: nothing was checked visually (no screenshots), and no new CSS was added.

Try it: open any pull on the preview. You get the dot, one check line, Ship if it's yours to ship, and "More" under the comment box. Cmd-K then "#N" lists every action.

The pull page now shows less at rest, and every action it had is still on the page or in Cmd-K. This push fixes the four failures from the check.

What changed

• The state badge is now a dot with an aria-label and a data-state. Merged, Closed and Parked are also written beside it; open is the only state shown as a dot alone.
• The check is one muted line with a dot and its note, and the card around it is gone. A state that needs someone has its word written out.
• The Decide card is now a plain block (id="decide") holding the one primary action.
• The path line carries "Next: …" in the same paragraph, and the per-step tooltips are dropped.
• Hold and Take it back fold under a "More" disclosure below the conversation. A hold that is already set still shows as its own card.
• The where strip, with its "keep on my machine" pin, no longer appears on a pull's page. It stays on the repository's home, and the palette has a "Where it is read from" row for it.
• A new pullActions puts these in the palette, each only where the viewer may use it: Conversation, Files, Ship (or Bring up to date when the branch conflicts), Check again, Hold, Comment, Close pull request, Edit and Take it back.
• docs/design/areas/pull.md says in one line what the page is for.

The page is smaller. The HTML went from 31,968 to about 31,030 bytes on the snappy fixture. The budget in test/pull-quiet.test.ts is now 31,500, still under the old size.

The four failures

• The dot had lost the data-state="closed" that test/web-ui.test.ts checks, so I restored it. The second web-ui failure ("the composer, the verdicts…") passes again after that fix and I didn't look into it separately.
• test/parked-close.test.ts looked for the old badge markup. It now looks for the word "Parked" or "Closed" beside the dot.
• test/pull-quiet.test.ts failed in the check but passed for me. My guess is its budget was too tight: the old margin was about 90 bytes, and page size varies with ports and times. I widened it to 31,500 and did not reproduce the failure, so I haven't confirmed that was the cause.
• Locally, test/pull-quiet.test.ts, test/web-ui.test.ts, test/parked-close.test.ts, test/studio-shipping.test.ts, test/holds.test.ts and test/pulls.test.ts pass. tsc, scripts/gate.ts and scripts/design-lint.ts were clean on the first push; I didn't re-run them after this fix.
• I also edited test/holds.test.ts and test/studio-shipping.test.ts, which asserted the old Hold summary and the <h2>Decide</h2> heading. They now check id="hold" and id="decide".

Not done

• The desk and phone screenshots are missing; the sandbox can't take them, so someone needs to add them from the preview.
• The HTML saving is only about 3%, because the shared repo header and the thread composer make up most of the page. I left both alone because other pages use them.

Try it: open any pull on the preview. You get the dot, one check line, Ship if it's yours to ship, and "More" under the comment box. Cmd-K then "#N" lists every action.

I merged main into the branch, resolved the two conflicts, and pushed. tsc, the gate and the design lint are clean. The seven pull-related test files I ran pass, but I did not run the full suite.

main had gained pull #8800, which already rebuilt much of the pull page, including its own test/pull-quiet.test.ts. I resolved as follows:

• change.ts: I kept main's check line and take-back wording where our changes overlapped, and kept the parts only this pull has. Those are the state dot, the palette actions (pullActions), the "More" fold for Hold and Take it back, the plain Decide block, and the quieter header with no where strip.
• test/pull-quiet.test.ts: I took main's version unchanged. My guard test is now test/pull-actions.test.ts (byte budget, every action on the page, every action in the palette), so nothing of it is lost.
• Test edits: the earlier edits to test/holds.test.ts, test/studio-shipping.test.ts and test/parked-close.test.ts are unchanged.

The two pulls now overlap in intent. If a person prefers main's page as is, the part unique to this pull is the palette actions, the "More" fold and the where-strip removal.

The desk and phone screenshots are still missing, because the sandbox can't take them.

I addressed items 1, 3, 4, 5, 6 and 7. Item 2 (the screenshots) is not done, and I disagree with part of item 6. I ran tsc, scripts/gate.ts, scripts/design-lint.ts and the eight related test files, including both pull-quiet and pull-actions; all pass.

1. Hold and Take it back from Cmd-K: their palette rows now go to ?more=1#hold and ?more=1#take-back. When the URL has ?more, the server renders the "More" details already open, so the target is visible with JavaScript on or off. I chose this because a :target rule can't open a closed <details>. test/pull-actions.test.ts checks the palette hrefs and that the details is closed without ?more and open with it. The merged-pull test checks the same for #take-back.
2. Screenshots: still not attached. The sandbox has no browser and can't reach the preview with one, so someone needs to add the before and after desk and phone looks.
3. Byte budget: there is now one budget, in main's test/pull-quiet.test.ts. I took it from 32,000 to 31,100. I removed my own duplicate from test/pull-actions.test.ts. On that fixture's open pull, the page was 31,968 bytes before this pull and 31,622 on main after #8800, according to that test's comment. It is 30,889 now, about 2.3% smaller than main. I could not measure main myself here (a second checkout was blocked), so the 31,622 is the comment's figure.
4. The "More" disclosure: it is now <details class="mt mb" id="more">, the same disclosure Hold used, and the more class is gone. docs/design/areas/pull.md is rewritten to match.
5. Hold, Check again, primary count:

- Check again has its icon back. - The hold form has a visible "Hold this pull request" label, and the "More: hold, take it back" summary names what is inside. - There is exactly one primary button: Comment steps down when Ship is on the page.

1. Tests:

- New tests check that a reader sees none of the private actions or id="more", and that a merged pull has Take it back on the page and in the palette. - Every-action reachability is still only proven against the new page, because this pull never ran its test against the old one. I accept the gap. - I restored the "Hold this pull request" assertion in test/holds.test.ts beside id="hold". - I disagree that id="decide" in test/studio-shipping.test.ts is weaker. It marks the same block as the old <h2>Decide</h2>, and the test still asserts the Ship button.

1. Terminal: src/tui/screens/pull.ts draws its own rows and shares no markup with the web page, so it needs no change.

Left #8773 open: 1 unticked item remain (Desk and phone screenshots, before and after, are attached to the pull as looks. docs/design/areas/pull.md says in one line what the page is for, so a cold reader gets it in 10 seconds.).