Public: anyone can read this; the crew can change it.
Bets: the owner backs a few named wholes with a share of the week, and the crew finishes them #8723
I fixed four of the six failing checks and pushed. The other two, in test/stalereds.test.ts, are not caused by this pull and I left them. What was wrong Server-Timing: /bets and /bets/:id didn't name session and render phases.
stopped closed without shipping deploy 83ff288
I fixed four of the six failing checks and pushed. The other two, in test/stale_reds.test.ts, are not caused by this pull and I left them.
What was wrong
- Server-Timing:
/betsand/bets/:iddidn't namesessionandrenderphases. Both now do. - MCP tool list:
test/mcp.test.tsdidn't list the newbetstool. I added it. - Asks first: the new
betstool writes but wasn't named in the asks-first list. I added it toNOT_ASKEDintest/conversation-confirm.test.ts. The tool gates the owner-only actions itself. - Unseeded routes:
/:owner/:name/bets/:idneeds a backed bet, which the seeded test forge doesn't have. I named it inUNSEEDEDintest/security-floor-routes.test.ts.
Checks I ran
tscis clean.scripts/gate.tsis clean.- Four affected test files and
test/bets.test.tspass (90 tests): Server-Timing sweep, security-floor routes, MCP and asks-first.
Still red: test/stale_reds.test.ts
- Two tests fail there: "a pull past its tries is parked…" and "the flow report counts stale reds…".
- They fail identically on the parent commit
a893d366, which is the base this pull branched from. I haven't diagnosed why.
Declined: already done on the branch in 83ff2887 and c3b229f3. The owner's addition (after a day with nothing backed, the planner's top proposals start at a modest share, marked not backed by the owner, and one tap stops any of them) is already built. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m6em9xrjxd1w6tvrrfcx4y7h
I fixed four of the six failing checks and pushed. The other two, in
test/stale_reds.test.ts, are not caused by this pull and I left them.What was wrong
/betsand/bets/:iddidn't namesessionandrenderphases. Both now do.test/mcp.test.tsdidn't list the newbetstool. I added it.betstool writes but wasn't named in the asks-first list. I added it toNOT_ASKEDintest/conversation-confirm.test.ts. The tool gates the owner-only actions itself./:owner/:name/bets/:idneeds a backed bet, which the seeded test forge doesn't have. I named it inUNSEEDEDintest/security-floor-routes.test.ts.Checks I ran
tscis clean.scripts/gate.tsis clean.test/bets.test.tspass (90 tests): Server-Timing sweep, security-floor routes, MCP and asks-first.Still red:
test/stale_reds.test.tsa893d366, which is the base this pull branched from. I haven't diagnosed why.Continues #8723