An ask always offers the action that settles it: an assigned pull is not a page with only Open #8706

An assigned pull or issue on /asks now has buttons that settle it, and a pull a person holds with changes requested goes back to its builder after a day of their silence. I ran tsc, gate.ts, design-lint and nine ask-related test files (64 tests, including the new ones); all pass. I did not run the full suite or any browser check. A green check with no change requested also shows Land, but I couldn't make that card appear in a test.

What changed

• Assigned asks: an assigned pull or issue now offers Give to the crew, Close and Open, with Land added for a pull whose latest check is green and has no change requested.

- Give to the crew goes to the crew member who last ran on it, otherwise a builder on the crew. - Land is not shown when the pull has no green check or has a change requested. - Before, Give to the crew only worked on a pull a pass had handed over. - It now works on any pull or issue assigned to the viewer, through the same POST /asks/give-back, MCP and CLI doors.

• Stranded pulls: src/crew/stranded.ts runs at the start of every autonomy tick, over all repositories (not only autonomous ones).

- A pull qualifies when a person holds it and the crew reviewer's newest verdict is changes requested. The person must have said nothing since that verdict for 24 hours, and the pull must not be on hold. - It is then given to its builder, with a comment, up to 3 per tick. - It reads the database each tick and keeps no memory. It caught the pulls already stranded when it first ran, and a pull no longer matches once it is given back, so each is given back once.

• Tests: test/ask-settles.test.ts walks every DecisionKind and fails if one has no settling button. ASK_WORDS is the list it walks, so a new kind added there is covered. The file also covers the assigned pull and issue actions and the sweep (stuck, too fresh, person spoke, never reviewed, once only).
• Existing test changed: in test/pass-handover-ask.test.ts I changed two expectations that were wrong under the new rule. A plain assignment can now be given back, and a "not your reason" note no longer blocks it.

Left out

• The TUI and CLI card renderers are untouched; they reach Give to the crew through the existing endpoint.
• A pull whose author was a person, with no crew run on it, has no builder to go back to, so it still only offers Close. The sweep skips it.

How to try it Assign yourself a pull or issue in a repo with a crew, then open /asks. For the sweep, make a crew reviewer request changes on a pull assigned to you and wait a day; bun test test/ask-settles.test.ts shows the same.

Closes #8699

An assigned pull or issue on /asks now has buttons that settle it, and a pull a person holds with changes requested goes back to its builder after a day of their silence. I ran tsc, gate.ts, design-lint and nine ask-related test files (64 tests, including the new ones); all pass. I did not run the full suite or any browser check. A green check with no change requested also shows Land, but I couldn't make that card appear in a test.

What changed

• Assigned asks: an assigned pull or issue now offers Give to the crew, Close and Open, with Land added for a pull whose latest check is green and has no change requested.

- Give to the crew goes to the crew member who last ran on it, otherwise a builder on the crew. - Land is not shown when the pull has no green check or has a change requested. - Before, Give to the crew only worked on a pull a pass had handed over. - It now works on any pull or issue assigned to the viewer, through the same POST /asks/give-back, MCP and CLI doors.

• Stranded pulls: src/crew/stranded.ts runs at the start of every autonomy tick, over all repositories (not only autonomous ones).

- A pull qualifies when a person holds it and the crew reviewer's newest verdict is changes requested. The person must have said nothing since that verdict for 24 hours, and the pull must not be on hold. - It is then given to its builder, with a comment, up to 3 per tick. - It reads the database each tick and keeps no memory. It caught the pulls already stranded when it first ran, and a pull no longer matches once it is given back, so each is given back once.

• Tests: test/ask-settles.test.ts walks every DecisionKind and fails if one has no settling button. ASK_WORDS is the list it walks, so a new kind added there is covered. The file also covers the assigned pull and issue actions and the sweep (stuck, too fresh, person spoke, never reviewed, once only).
• Existing test changed: in test/pass-handover-ask.test.ts I changed two expectations that were wrong under the new rule. A plain assignment can now be given back, and a "not your reason" note no longer blocks it.

Left out

• The TUI and CLI card renderers are untouched; they reach Give to the crew through the existing endpoint.
• A pull whose author was a person, with no crew run on it, has no builder to go back to, so it still only offers Close. The sweep skips it.

How to try it Assign yourself a pull or issue in a repo with a crew, then open /asks. For the sweep, make a crew reviewer request changes on a pull assigned to you and wait a day; bun test test/ask-settles.test.ts shows the same.

Every ask row now carries a typed elicitation with its buttons. The assigned-ask actions and the one-day sweep from the first push are unchanged. tsc, gate.ts, design-lint and 264 tests across 38 ask-related files all pass. I did not run the full suite. fast.ts named 1331 test files, so I picked the ask, MCP, CLI, TUI and contract suites myself.

What changed

• Each row from askLinesFor has elicitation: { type: "elicitation", awaiting: "input", actions }. asksAnswer, the MCP asks tool and the API read the same rows, so they carry it automatically.
• Each action is a named call or a link, not free text:

- Calls: the existing asks_act (ship, close, decline), asks_decide (give back, let the decider), asks_proposal and say tools, each with its arguments filled in. - Text: an action that needs words (say, proposal redirect) sets needs: "text", so the caller supplies only that. - Links: a paused repository gets a link to the settings page, since no tool raises the ceiling.

• The actions per kind are in src/web/studio/elicitation.ts. An assigned row, for example, offers Give to the crew, Land and Close.
• A grouped row of several asks keeps only the bulk asks_act moves, because there is no single pull to speak on or decide. If none apply, it gets an Open link.

Tests (added to test/ask-settles.test.ts)

• Every DecisionKind yields a typed elicitation awaiting input, with at least one action that is a call or a link.
• A group row is limited to the bulk moves.
• An assigned row's elicitation lists Give to the crew, Land and Close, in that order.

Left out

• Land is always listed in an assigned row's elicitation. Whether landing is allowed is only checked on the web card, which hides the button; asks_act ship refuses at call time.
• The web, TUI and CLI card renderers are not changed to read the elicitation.

I fixed the four failures in test/app-home-batched.test.ts and pushed. I did not touch the fifth, the PNG test in test/render-image.test.ts. It passes when run alone (12 of 12), so it looks like a flake in a shared shard. It needs a second look if it fails again on the next check.

Cause: the assigned-ask rows I added looked up their builder with one query for the runs and one for the crew per assigned row. With 200 open issues the home page ran about 50 of each instead of about 12.

Fix: crewHandsFor in src/actions/give_back.ts finds the builders for all rows with a fixed number of queries, and src/web/studio/asks.ts now uses it. It gives the same answers as the single-row lookup. The single-row crewHandFor stays for the Give to the crew action and the one-day sweep, which touch one pull at a time.

I re-ran test/app-home-batched.test.ts, test/ask-settles.test.ts, test/pass-handover-ask.test.ts, test/asks.test.ts and test/crew-loop.test.ts (40 tests), plus tsc and gate.ts. All pass. The forge's check will run the full suite again on this push.

The two failing stale-reds tests were a clock problem in the tests, not a bug in this pull. They pass locally now and the fix is pushed. I did not run tsc or the gate, since the change is one line in a test file.

test/stale_reds.test.ts fixed its pretend "now" at 2026-11-02 12:00. The pull that test creates is stamped with the real clock, and today's date had passed 17:00 by the time the check ran. The test's runs then fell before the pull's creation and no longer counted as automatic tries. The first test saw a re-check queued instead of the pull parked. The flow-report test counted six stale reds instead of five.

I moved the test's start time to 2090-01-01 so it stays ahead of the real clock. Only test/stale_reds.test.ts changed. The forge's full check will run again on this push.

The review feedback is addressed and pushed. The tests I ran pass, plus tsc, the gate and the design lint. I did not run the full suite or touch the preview.

Changes

• Scope: I reverted the typed-elicitation commit. src/web/studio/elicitation.ts, its use in asks.ts and its tests are gone.
• One accent: on an assigned card only the first action is primary, and Land is now a plain button. A new test counts the primary buttons.
• Terminal:

- b now gives any assigned pull or issue to the crew, not only a handed-over pull. The action still decides whether a builder exists. - Close and Ship already acted on any On you row (x, S), so I added nothing for them. - I updated test/tui-pass-give-back.test.ts, where "a plain assignment makes b refuse" was the old behaviour. It now expects the pull to go to the builder. - I kept the "b give back to the crew" hint out of the pane title for plain rows. It pushed text out of the title in tui-onyou; the key bar shows it.

• Docs: new docs/features/ask-settles.md covers the actions on an assigned ask and the one-day sweep.
• Sweep actor: the reassignment is now recorded under the person who switched autonomy on for the repository, as the stale-red sweep does. It falls back to the holder only if there is none. The comment in the code says so. The comment on the pull itself is STRANDED_LINE as before, so it still doesn't say the forge posted it. If you want it to, I can reword it.
• Stale-red fixtures: T0 is now the real time when the file loads, not a date in 2090. The runs are still placed relative to T0, so the file no longer depends on the day it runs.
• Batch vs single read: a test checks that crewHandsFor names the same crew member as crewHandFor across pulls, issues and unassigned work. I did not merge the two functions, since the batch one exists to avoid a query per row.

The diff was too broad for scripts/fast.ts to name tests, so I ran ask-settles, stale_reds, pass-handover-ask, tui-pass-give-back, tui-onyou and about 20 other ask, home and terminal tests. The forge runs the full check on this push.

I merged main into the branch and pushed it. The only conflict was in test/stale_reds.test.ts.

main had made the same clock fix I'd made there, so I kept its comment and dropped mine. tsc is clean. The tests I re-ran pass: stale_reds, ask-settles, tui-pass-give-back and tui-onyou. I didn't run the full suite; the forge's check will on this push.

Every ask now offers an action that settles it. A pull or issue assigned to a person can go to the crew, be closed, or land, and Land shows only when the check is green and no change is asked of the current head. On the card, Give to the crew is the only primary button; Land and Close are plain. In the terminal, b gives any assigned row to the crew. x closes and S ships, as they already did.

A pull a person holds with changes requested by a crew reviewer goes back to its builder after a day of silence (src/crew/stranded.ts). The day counts from the latest of three moments: the verdict, the person's last comment or review, and when the pull was assigned to them. The assignment time comes from the newest pull.assigned event, read through the same event index the dispatcher uses. Only a verdict on the current head counts, so a change asked of an older push strands nothing. The sweep moves at most three pulls per tick. The reassignment is recorded under the person who switched autonomy on for the repository, falling back to the holder. The comment the sweep leaves does not say the forge posted it.

What to look at:

• crewHandsFor (in src/actions/give_back.ts) keeps the five newest agent runs per issue in SQL with ROW_NUMBER(). A test checks it names the same crew member as crewHandFor.
• Settling paths: the every-kind test in test/ask-settles.test.ts follows each button's form= to the form decisionForm renders and checks where it posts, per kind.
• Land: tested through decisionsFor, both green with nothing asked and green with a change requested on the head. The second test runs in an autonomous repository. Elsewhere a green crew pull with a reviewer's verdict shows as a "look" card, which has its own Ship button, so there is no assigned card to test.

Mutation checks on the new tests:

• Removing the change-requested check, the assignment time or the head-aware verdict fails three of them.
• Removing the green-check condition fails a fourth.

What changed in existing code and tests:

• Elicitation module removed: the typed-elicitation commit is reverted as out of scope; it would have listed Land whether or not the pull could land.
• test/tui-pass-give-back.test.ts changed: a plain assignment now goes to the builder on b instead of refusing.
• test/pass-handover-ask.test.ts relaxed: it no longer checks that a note posted by someone other than the assignee unlocks nothing. Being the assignee is now the only gate, and giveBack still requires the assignee and write access.

docs/features/ask-settles.md covers the actions and the sweep.

Checks run: tsc, scripts/gate.ts and design lint are clean. The diff was too broad for scripts/fast.ts to name tests, so I ran ask-settles, stale_reds, pass-handover-ask, stall-scans, tui-pass-give-back, tui-onyou and every test that imports the asks, give-back or sweep modules; all pass. The full suite was not run here. The preview has not been looked at.

To try it: assign yourself a crew pull and open /asks. The card offers Give to the crew and Close, plus Land when the pull is green with nothing asked. In the terminal's On you pane, b hands the row under the cursor to the crew.

🤖 Generated with Claude Code