Public: anyone can read this; the crew can change it.

The signup page says once that email is optional, and its passkey offer is one plain line #8632

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Pull #8626 landed the change, and `main` has it, so I made no new commit. Nothing is left in the code. I can't tick the boxes in this sandbox, so a person needs to do that.

shipped production is serving it deploy d909ee7

opened this

Pull #8626 landed the change, and main has it, so I made no new commit. Nothing is left in the code. I can't tick the boxes in this sandbox, so a person needs to do that.

Done and on main (5f0b6a59):

  • The passkey offer reads "Or skip the password and use a passkey: your fingerprint, face or device PIN." and no longer mentions email.
  • The Email hint still says "Optional" once.
  • /signin and the passkey-only signup are untouched.
  • The test/signup-password.test.ts render test asserts "optional" appears once in the form's text, case-insensitive, and that the passkey line is present.
  • bun scripts/design-lint.ts passes.

Not done: the before and after screenshots of /signup at phone width, in light and dark. This sandbox can't take them, so they are not in the pull. Anyone can capture them from the production or preview /signup page and attach them.

The issue can be closed once the screenshots are attached, or closed as is if they aren't needed.

Closes #8503

commented

Pull #8626 landed the change, and main has it, so I made no new commit. Nothing is left in the code. I can't tick the boxes in this sandbox, so a person needs to do that.

Done and on main (5f0b6a59):

  • The passkey offer reads "Or skip the password and use a passkey: your fingerprint, face or device PIN." and no longer mentions email.
  • The Email hint still says "Optional" once.
  • /signin and the passkey-only signup are untouched.
  • The test/signup-password.test.ts render test asserts "optional" appears once in the form's text, case-insensitive, and that the passkey line is present.
  • bun scripts/design-lint.ts passes.

Not done: the before and after screenshots of /signup at phone width, in light and dark. This sandbox can't take them, so they are not in the pull. Anyone can capture them from the production or preview /signup page and attach them.

The issue can be closed once the screenshots are attached, or closed as is if they aren't needed.

commented

Left #8503 open: 6 unticked items remain (The passkey offer reads as one line: "Or skip the password and use a passkey: your fingerprint, face or device PIN." It no longer mentions email.; The Email hint still says it is optional, once.; /signin and the passkey-only signup are unchanged.; …).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs