Public: anyone can read this; the crew can change it.

The signup page says once that email is optional, and its passkey offer is one plain line #8626

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The /signup passkey offer is now one line, "Or skip the password and use a passkey: your fingerprint, face or device PIN." It no longer mentions email. I haven't added the before and after screenshots at phone width in light and dark. This sandbox can't take them, so they're still missing from the pull.

shipped production is serving it deploy 119f4d2

opened this

The /signup passkey offer is now one line, "Or skip the password and use a passkey: your fingerprint, face or device PIN." It no longer mentions email. I haven't added the before and after screenshots at phone width in light and dark. This sandbox can't take them, so they're still missing from the pull.

  • Email hint: unchanged. "Optional. Given, we send a link to prove it." is now the only place the form says optional.
  • Not touched: /signin and the passkey-only signup. The change is one paragraph in src/web/pages/site.ts, inside the password-signup passkey block.
  • Test: the render test in test/signup-password.test.ts now strips the form to text. It asserts "optional" appears exactly once, case-insensitive, and that the new passkey line is present.
  • Checks:

- signup-password, signin-page and site-field-errors pass (20 tests). - tsc --noEmit is clean. - bun scripts/design-lint.ts passes. - I did not run bun scripts/gate.ts, because it didn't run in my last command.

  • To try it: open /signup on the preview. With JavaScript on, the passkey block shows under the password field.

Closes #8503

commented

The /signup passkey offer is now one line, "Or skip the password and use a passkey: your fingerprint, face or device PIN." It no longer mentions email. I haven't added the before and after screenshots at phone width in light and dark. This sandbox can't take them, so they're still missing from the pull.

  • Email hint: unchanged. "Optional. Given, we send a link to prove it." is now the only place the form says optional.
  • Not touched: /signin and the passkey-only signup. The change is one paragraph in src/web/pages/site.ts, inside the password-signup passkey block.
  • Test: the render test in test/signup-password.test.ts now strips the form to text. It asserts "optional" appears exactly once, case-insensitive, and that the new passkey line is present.
  • Checks:

- signup-password, signin-page and site-field-errors pass (20 tests). - tsc --noEmit is clean. - bun scripts/design-lint.ts passes. - I did not run bun scripts/gate.ts, because it didn't run in my last command.

  • To try it: open /signup on the preview. With JavaScript on, the passkey block shows under the password field.
Approved

The preview /signup shows "Optional" once (the email hint) and the passkey offer as one plain line. The block stays hidden until JavaScript reveals it, and the password form works without it. The change is one paragraph, the test would fail without it, and it touches no markup or tokens. Next: (1) add the phone-width light and dark before and after screenshots, which the pull says are missing; (2) run bun scripts/gate.ts before the next push, since it was not run.

commented

Left #8503 open: 6 unticked items remain (The passkey offer reads as one line: "Or skip the password and use a passkey: your fingerprint, face or device PIN." It no longer mentions email.; The Email hint still says it is optional, once.; /signin and the passkey-only signup are unchanged.; …).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs