A list route given a cursor or state it cannot read answers 422, never page one again #8624

Issue and pull lists now refuse a bad cursor or state with a 422, and repository lists refuse a cursor outside the id alphabet. Pushed; the forge's check will run on it. I ran about 120 test files and bun x tsc --noEmit clean, plus a bun scripts/gate.ts run that printed nothing. I did not run the whole suite. scripts/fast.ts named nearly every test file, so I picked the files that mention cursors, states or the contract myself. One of the runs printed a <sandbox_violations> block (denied outbound connection to ::1:45999), and those tests still passed.

What changed

• listQuery (src/http/api.ts):

- An unreadable cursor answers 422 invalid_cursor ("cursor is the next_cursor of a previous page"). A readable cursor is a positive integer. - Any state other than open, closed or all answers 422 invalid_state ("state is open, closed or all"), so state=bogus and state=Closed no longer list open issues. - An absent state still means open, and an absent cursor still means page one.

• repoQuery: a cursor outside ^[A-Za-z0-9_-]{1,64}$ answers 422 invalid_cursor. This also covers /api/v1/users/:username/repos, which shares it.
• Contract: the four affected routes list the new refusals under refusals in src/contract/openapi/routes/.
• Tests (test/list-cursor-state.test.ts, new): each refusal on /repos/:o/:n/issues, /pulls, /repos and /users/:u/repos, including %25%25. Another test follows next_cursor through every page of issues (5 rows), pulls (5) and repos (6) at limit=2, and checks that every row is seen once. The pull rows are inserted straight into the pull table, because the real open-pull path needs git branches.

Choices

• Empty values are refused: cursor= and state= with nothing after them are 422, because they are not a cursor or a state. Before, an empty cursor meant page one.
• /repos walk takes an extra page: the six-repo walk at limit=2 takes four requests, so the last page is empty with a non-null next_cursor. That comes from how the repo lists are paged, not from this change, and I left it alone. The walk test asserts that every row is seen once and that the walk ends.
• #8490 was already on the base: listQuery and repoQuery already had the invalid_limit handling, so there was no conflict.

To try it: curl -i 'https://lab--forge-trevato-apps.open-platform.sh/api/v1/repos?cursor=%25%25' should answer 422 once this lands. A preview is deployed from the pull.

🤖 Generated with Claude Code

Closes #8504

Issue and pull lists now refuse a bad cursor or state with a 422, and repository lists refuse a cursor outside the id alphabet. Pushed; the forge's check will run on it. I ran about 120 test files and bun x tsc --noEmit clean, plus a bun scripts/gate.ts run that printed nothing. I did not run the whole suite. scripts/fast.ts named nearly every test file, so I picked the files that mention cursors, states or the contract myself. One of the runs printed a <sandbox_violations> block (denied outbound connection to ::1:45999), and those tests still passed.

What changed

• listQuery (src/http/api.ts):

- An unreadable cursor answers 422 invalid_cursor ("cursor is the next_cursor of a previous page"). A readable cursor is a positive integer. - Any state other than open, closed or all answers 422 invalid_state ("state is open, closed or all"), so state=bogus and state=Closed no longer list open issues. - An absent state still means open, and an absent cursor still means page one.

• repoQuery: a cursor outside ^[A-Za-z0-9_-]{1,64}$ answers 422 invalid_cursor. This also covers /api/v1/users/:username/repos, which shares it.
• Contract: the four affected routes list the new refusals under refusals in src/contract/openapi/routes/.
• Tests (test/list-cursor-state.test.ts, new): each refusal on /repos/:o/:n/issues, /pulls, /repos and /users/:u/repos, including %25%25. Another test follows next_cursor through every page of issues (5 rows), pulls (5) and repos (6) at limit=2, and checks that every row is seen once. The pull rows are inserted straight into the pull table, because the real open-pull path needs git branches.

Choices

• Empty values are refused: cursor= and state= with nothing after them are 422, because they are not a cursor or a state. Before, an empty cursor meant page one.
• /repos walk takes an extra page: the six-repo walk at limit=2 takes four requests, so the last page is empty with a non-null next_cursor. That comes from how the repo lists are paged, not from this change, and I left it alone. The walk test asserts that every row is seen once and that the walk ends.
• #8490 was already on the base: listQuery and repoQuery already had the invalid_limit handling, so there was no conflict.

To try it: curl -i 'https://lab--forge-trevato-apps.open-platform.sh/api/v1/repos?cursor=%25%25' should answer 422 once this lands. A preview is deployed from the pull.

🤖 Generated with Claude Code

Left #8504 open: 4 unticked items remain (Issue and pull lists answer 422 invalid_cursor ("cursor is the next_cursor of a previous page") for a cursor that is not a positive integer, and 422 invalid_state ("state is open, closed or all") for any other state. An absent state still means open.; Repository lists answer 422 invalid_cursor for a cursor outside the id alphabet pageParams already checks (^[A-Za-z0-9_-]{1,64}$).; Following each route's next_cursor still walks every page; the tests prove it on a list of three pages.; …).