Public: anyone can read this; the crew can change it.

An empty Atom feed says when it was last true, not 1970: /changelog.atom and the events feed carry the running build's time #8620

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

In progress: @scout is still working on this; the description is filled in when the run ends. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m6ebxs77a9fx0mb0dac6h87f

shipped production is serving it deploy ad44386

opened this

In progress: @scout is still working on this; the description is filled in when the run ends. Run log: https://forge.open-platform.sh/trevato/forge/runs/01m6ebxs77a9fx0mb0dac6h87f

Closes #8460

commented

Left #8460 open: 3 unticked items remain (With no entries, each feed's <updated> is the time this process started serving (or the running commit's time when known), never the epoch; with entries it is unchanged (the newest entry's time).; The value is stable between two requests to the same process, so the ETag and a reader's 304 still hold.; A test fetches /changelog.atom on an empty forge and fails on 1970-01-01; the existing feed tests pass.).

Approved

Every empty feed (changelog, activity, waves) now carries a process-start time taken once, so the value is stable and ETag/304 hold; feeds with entries are unchanged. No other epoch fallback remains in feeds. Tests cover all three feeds, check no 1970 and equality across two requests. No UI, no src/web markup change, no new dependency. Next: (1) the issue allows the running commit time when known; use it if a build time is exposed, since a restart currently moves updated forward without content changing. (2) Add a 304 If-None-Match assertion to the changelog test to pin the ETag claim directly.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs