One home: the feed for every signed-in person; the dev dashboard leaves #857

Merged trevatoowner opened this 1mo agoin answer to trevatoowner

Check · Review · Land · Live done — Landed and live in production.

Conversation Files

Merged

Closes #625

shipped production is serving it for issue #625 — its issue is already done deploy 2fa0c24

trevatoowner opened this 1mo ago

Closes #625

In progress (steward build team). Description, removals and looks follow.

trevatoowner commented 1mo ago

Description (the pull body is fixed at open; this is it). Closes #625.

There is now one home. Signed in, / is the feed (#599) for every viewer and every mode; ?mode=dev and the mode cookie change nothing on /. A stranger still gets the door.

Path. Open / and see what is happening. The primary action is the composer; next is a post's thing.

Removed

dashboard() in src/web/pages/site.ts and what only it used: the repository list with its filter and paging, repoRow, the activity rail (activityRail, eventIcon, eventIssueRef, eventSubject), inbox, and needsYouCard.
appsCard and appRow in pages/apps.ts.
isTransientEvent in design/activity.ts: its last caller was the rail.
The studio home's app rows were already moved to /apps by #599.
Lines: src/ is +42/−448.

What the dashboard showed, and where it lives now

Your repositories, the filter, paging and counts: your own page, /:you (one owner page, #633), one tap away through the new Repositories button on the home's Your apps card. New repository is in the "+" menu and on your own page.
Needs you ("N things need you"): the header's Asks count, and the feed's own Needs you posts.
On you: the home rail's On you card (the same onYouCard).
Apps: the home rail's Your apps card, with full rows on /apps.
Recent activity: the feed itself.
Terminal (the ssh command), On your machine (pins and forge sync) and Your organizations: these three cards moved to the home's rail. Each shows only when it has something: an SSH listener, a pin, or an organization. Their empty-state explainers are dropped; the pin on a repository's header and the "+" menu say the rest.

Tests, updated rather than deleted:

studio: the home is the feed in dev mode too, and Repositories links to /alice.
event-audience: the home holds configuration back from a stranger in any mode.
web-origins: the home lists what is pinned.
asks: the header's count.
web-apps: Your apps on the home.
web-code: repository rows' counts are read on /alice.

Verified. tsc is clean. studio, web, feed-page, everyday, front, studio-words, asks, event-audience, web-origins, web-apps, web-code and the five cross files pass. surfaces-adversarial's "N+1: /apps" test fails on main too (74 queries against 24), so it is not this pull's. Looks at 390 and 1280 of / and /?mode=dev: the same page, with no sideways scroll.

🤖 Generated with Claude Code

trevatoowner commented 1mo ago

Additions to the description (review follow-ups).

The dashboard's list showed every repository you can see, with a filter and pin marks. /:you shows only your own repositories. Other people's are found through /search, the explorer (/explore) and their own pages. Pins show in the home's "On your machine" card.
The dashboard's c key (New repository) went with it. New repository is in the "+" menu and on your own page.
Head b66772b: the studio test for an empty home expects href="/erin" and no /?mode=dev.