Public: anyone can read this; the crew can change it.

Enter on a terminal event opens its issue or pull #8500

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

`enter` on a terminal event row opens its issue or pull. The branch is merged with the latest `main`, and I pushed it (`3550f4a7`).

shipped production is serving it deploy eb43263

opened this

enter on a terminal event row opens its issue or pull. The branch is merged with the latest main, and I pushed it (3550f4a7).

main had moved again since the last merge. This one merged without conflicts. The gate and tsc --noEmit are clean, and the 7 tests in test/tui-events.test.ts pass. I did not run the rest of the suite; the forge runs the full check on push.

  • Opens: enter on a row that names an issue or pull number pushes the matching screen with only that number. A pull.* event opens the pull, any other event the issue. The issue and pull screens check access themselves. esc returns to the events list at the same row.
  • Nothing to open: a push or settings row does nothing on enter. The key bar shows enter open only when the selected row can open something.
  • Narrowing: it still works with enter. It resets the list of openable rows when the list is re-read.

I did not add any other key to the events screen.

To try it, press v on the About card, move to a row and press enter.

Closes #8434

commented

enter on a terminal event row opens its issue or pull. The branch is merged with the latest main, and I pushed it (3550f4a7).

main had moved again since the last merge. This one merged without conflicts. The gate and tsc --noEmit are clean, and the 7 tests in test/tui-events.test.ts pass. I did not run the rest of the suite; the forge runs the full check on push.

  • Opens: enter on a row that names an issue or pull number pushes the matching screen with only that number. A pull.* event opens the pull, any other event the issue. The issue and pull screens check access themselves. esc returns to the events list at the same row.
  • Nothing to open: a push or settings row does nothing on enter. The key bar shows enter open only when the selected row can open something.
  • Narrowing: it still works with enter. It resets the list of openable rows when the list is re-read.

I did not add any other key to the events screen.

To try it, press v on the About card, move to a row and press enter.

commented

Left #8434 open: 4 unticked items remain (enter on a row whose event names an issue or pull number opens that issue or pull, pushing issueScreen (src/tui/screens/issue.ts:145) or pullScreen (src/tui/screens/pull.ts:216) the way other lists in the terminal open them. esc returns to the events list at the same row.; A row with nothing to open (a settings change, a push) does nothing, and the key bar shows enter open only when the selected row can open something.; The issue-or-pull choice follows the web page's rule (event.kind.startsWith("pull.") in src/web/pages/events.ts).; …).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs