Public: anyone can read this; the crew can change it.

Enter on a terminal event opens its issue or pull #8488

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

On the terminal events screen, `enter` now opens the issue or pull a row names. These commits were already on the branch and pushed from my earlier run. This run re-checked them and made no new changes, so the push reported nothing to send. The gate, `tsc --noEmit` and design-lint are clean, and the six tests in `test/tui-events.test.ts` pass. I did not run the full suite; the forge runs that on p…

shipped production is serving it deploy 7cfd21c

opened this

On the terminal events screen, enter now opens the issue or pull a row names. These commits were already on the branch and pushed from my earlier run. This run re-checked them and made no new changes, so the push reported nothing to send. The gate, tsc --noEmit and design-lint are clean, and the six tests in test/tui-events.test.ts pass. I did not run the full suite; the forge runs that on push.

  • Opening: enter on a row with an issue or pull number pushes issueScreen or pullScreen with only that number. Those screens already check access, so a number the reader can't see doesn't open. esc returns to the events list at the same row.
  • Issue or pull: the choice follows the web events page, so a pull.* kind opens the pull and anything else opens the issue.
  • Rows with nothing to open: a settings change or a push does nothing on enter. The key bar shows enter open only when the selected row can open something.
  • Tests: test/tui-events.test.ts covers a pull.merged row opening the pull, an issue.opened row opening the issue, a settings row staying put, and the key bar offering enter open only where it works. The how-to also says enter.

To try it, press v on the About card to reach the events screen, move to a row and press enter.

I chose not to add any other key or behaviour to the events screen.

Closes #8434

commented

On the terminal events screen, enter now opens the issue or pull a row names. These commits were already on the branch and pushed from my earlier run. This run re-checked them and made no new changes, so the push reported nothing to send. The gate, tsc --noEmit and design-lint are clean, and the six tests in test/tui-events.test.ts pass. I did not run the full suite; the forge runs that on push.

  • Opening: enter on a row with an issue or pull number pushes issueScreen or pullScreen with only that number. Those screens already check access, so a number the reader can't see doesn't open. esc returns to the events list at the same row.
  • Issue or pull: the choice follows the web events page, so a pull.* kind opens the pull and anything else opens the issue.
  • Rows with nothing to open: a settings change or a push does nothing on enter. The key bar shows enter open only when the selected row can open something.
  • Tests: test/tui-events.test.ts covers a pull.merged row opening the pull, an issue.opened row opening the issue, a settings row staying put, and the key bar offering enter open only where it works. The how-to also says enter.

To try it, press v on the About card to reach the events screen, move to a row and press enter.

I chose not to add any other key or behaviour to the events screen.

commented

I merged main into the branch, resolved three conflicts, and pushed (0e3114e6); the gate and tsc are clean and the 7 tests in test/tui-events.test.ts pass. I did not run the rest of the suite.

The conflicts were in src/tui/screens/events.ts, test/tui-events.test.ts and docs/features/events.md. main had added kind narrowing on the terminal events screen (t keeps the row's kind, s keeps settings changes) in the same places I had added enter. I kept main's version of all three files, which already contains my enter change.

Narrowing and enter work together. The list of rows that can open something is cleared whenever the list is re-read, so enter still opens the right issue or pull after narrowing.

commented

Left #8434 open: 4 unticked items remain (enter on a row whose event names an issue or pull number opens that issue or pull, pushing issueScreen (src/tui/screens/issue.ts:145) or pullScreen (src/tui/screens/pull.ts:216) the way other lists in the terminal open them. esc returns to the events list at the same row.; A row with nothing to open (a settings change, a push) does nothing, and the key bar shows enter open only when the selected row can open something.; The issue-or-pull choice follows the web page's rule (event.kind.startsWith("pull.") in src/web/pages/events.ts).; …).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs