Public: anyone can read this; the crew can change it.
Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:6ryojgfus8 was degraded 124 minutes today: trevato/forge: "the proxy adds under 5 ms (median) and 20 ms (p95) with the toolbar rewrite" failed on 3 pulls in the l… #8399
Check · Review · Land · Live done — Landed and live in production.
scout/forge:scout/8391-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 2 commits fork 1 thread · 1 unresolved
1 file
changed +6
−4
test/apps-proxy-overhead.test.ts +6 −4
| @@ -24,7 +24,7 @@ const DOMAIN = "apps.test"; | ||
| 24 | 24 | const RUNS = 25; |
| 25 | 25 | const MEDIAN_MS = 5; |
| 26 | 26 | const P95_MS = 20; |
| 27 | const ROUNDS = 12; | |
| 27 | const ROUNDS = 20; | |
| 28 | 28 | // About the size of the scaffold app's home page. |
| 29 | 29 | const PAGE = `<!doctype html><html><head><title>notes</title></head><body>${"<p>hello hello hello</p>".repeat(60)}</body></html>`; |
| 30 | 30 | |
| @@ -128,13 +128,15 @@ for (const [label, pill] of [["with the toolbar rewrite", undefined], ["without | ||
| 128 | 128 | toolbar = pill; |
| 129 | 129 | const direct = `http://127.0.0.1:${backend.port}/`; |
| 130 | 130 | const proxied = `${servers.url}/`; |
| 131 | for (let i = 0; i < 2; i++) { | |
| 131 | // The first test in the file pays for cold code (the rewrite, the JIT) that | |
| 132 | // the second never sees, so warm both paths well past the first few calls. | |
| 133 | for (let i = 0; i < 30; i++) { | |
| 132 | 134 | await time(direct, { accept: "text/html" }); |
| 133 | 135 | await time(proxied, HEADERS); |
| 134 | 136 | } |
| 135 | 137 | // Load only ever adds time, so the proxy's own cost is the floor of what |
| 136 | // is measured: judge the lowest median and the lowest p95 over a dozen short | |
| 137 | // rounds. A change that costs more than the budget raises that floor in | |
| 138 | // is measured: judge the lowest median and the lowest p95 over several short | |
| 139 | // rounds (ROUNDS). A change that costs more than the budget raises that floor in | |
| 138 | 140 | // every round and fails; a noisy round cannot. |
| 139 | 141 | let median = Infinity; |
| 140 | 142 | let p95 = Infinity; |
new above
offline
Non-blocking: name the warm-up count (e.g. WARMUPS = 30) beside ROUNDS and RUNS.