Public: anyone can read this; the crew can change it.
Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:3fnbnavt3j is past its budget: trevato/forge: "the upstream in the terminal > an admin sees the row, checks now, and turns following off and on" faile… #8350
Check · Review · Land · Live done — Landed and live in production.
scout/forge:scout/8348-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 1 thread · 1 unresolved
1 file
changed +8
−5
test/tui-upstream.test.ts +8 −5
| @@ -26,7 +26,8 @@ describe("the upstream in the terminal", () => { | ||
| 26 | 26 | let repo: Repo; |
| 27 | 27 | |
| 28 | 28 | function boot(identity: TuiIdentity) { |
| 29 | const terminal = headlessTerminal(120, 40); | |
| 29 | // Wide, so the footer lists every key the card offers instead of cutting the tail. | |
| 30 | const terminal = headlessTerminal(300, 40); | |
| 30 | 31 | const { app } = createForgeApp(forge, identity, { terminal, exitHooks: false }); |
| 31 | 32 | app.start(); |
| 32 | 33 | const press = async (...keys: string[]): Promise<void> => { |
| @@ -55,6 +56,8 @@ describe("the upstream in the terminal", () => { | ||
| 55 | 56 | ...(user === undefined ? {} : { user }), |
| 56 | 57 | }); |
| 57 | 58 | |
| 59 | // The upstream is a loopback address: the guard refuses it before any lookup | |
| 60 | // or connection, so the check never waits on DNS or the network. | |
| 58 | 61 | beforeAll(async () => { |
| 59 | 62 | dataDir = await mkdtemp(join(tmpdir(), "forge-tui-upstream-")); |
| 60 | 63 | forge = createApp({ dataDir, port: 0 }); |
| @@ -75,7 +78,7 @@ describe("the upstream in the terminal", () => { | ||
| 75 | 78 | repo = made.value; |
| 76 | 79 | putFollow(forge.db, { |
| 77 | 80 | repoId: repo.id, |
| 78 | url: "https://example.invalid/owner/armature.git", | |
| 81 | url: "https://127.0.0.1/owner/armature.git", | |
| 79 | 82 | branch: "main", |
| 80 | 83 | enabled: true, |
| 81 | 84 | byId: alice.id, |
| @@ -94,7 +97,7 @@ describe("the upstream in the terminal", () => { | ||
| 94 | 97 | try { |
| 95 | 98 | await openAbout(h); |
| 96 | 99 | expect(h.text()).not.toContain("upstream"); |
| 97 | expect(h.text()).not.toContain("example.invalid"); | |
| 100 | expect(h.text()).not.toContain("127.0.0.1"); | |
| 98 | 101 | await h.press("f"); |
| 99 | 102 | await h.press("u"); |
| 100 | 103 | expect(getFollow(forge.db, repo.id)?.enabled).toBe(true); |
| @@ -130,7 +133,7 @@ describe("the upstream in the terminal", () => { | ||
| 130 | 133 | const h = boot(as(alice)); |
| 131 | 134 | try { |
| 132 | 135 | await openAbout(h); |
| 133 | expect(h.text()).toMatch(/upstream +example\.invalid\/owner\/armature main/); | |
| 136 | expect(h.text()).toMatch(/upstream +127\.0\.0\.1\/owner\/armature main/); | |
| 134 | 137 | expect(h.text()).toContain("check upstream now"); |
| 135 | 138 | await h.press("u"); |
| 136 | 139 | await settleUntil(h.app, "could not be read"); |
| @@ -141,7 +144,7 @@ describe("the upstream in the terminal", () => { | ||
| 141 | 144 | expect(h.text()).not.toContain("check upstream now"); |
| 142 | 145 | await h.press("f"); |
| 143 | 146 | expect(getFollow(forge.db, repo.id)?.enabled).toBe(true); |
| 144 | expect(h.text()).toMatch(/upstream +example\.invalid/); | |
| 147 | expect(h.text()).toMatch(/upstream +127\.0\.0\.1/); | |
| 145 | 148 | } finally { |
| 146 | 149 | h.app.stop(); |
| 147 | 150 | } |
new above
offline
300 columns hides the footer truncation instead of fixing it. This is fine for this flake, but file the footer wrap/scroll as its own issue.