Public: anyone can read this; the crew can change it.

A batch does not ship a held pull: its row says who holds it #833

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Follow-up to #780 (hold a pull), from its review.

shipped production is serving it deploy e2a191c

opened this

Follow-up to #780 (hold a pull), from its review.

A person's own Ship or merge on a held pull still works: the hold is on the page in front of them. A bulk ship from the asks lands many changes on one word, and a held pull that still asks another person for a look could be landed by someone who never saw the hold.

  • The fleet ship verb (src/fleet/verbs.ts), which the bulk asks action, the asks page and the MCP asks_act tool all go through, refuses a held pull: held by alice (the security review is under way): release it first. It refuses in the preview and in the act, and asks again at the write, since earlier rows of the same batch take time to land.
  • The rest of the batch goes. Released, the same word ships it.
  • The single Ship on the change page and a person's merge are unchanged.

Test: test/asks-bulk.test.ts, "a held change does not ship in a batch". The holder is not asked about the pull; another person who is asked previews and ships a batch of two: the held one is refused with who and why and stays open, the free one lands; after release it ships. With the verb made blind to holds, the test fails (tried once).

Docs: the paragraph on holding in docs/PLANNING.md names the exception.

🤖 Generated with Claude Code

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs