Public: anyone can read this; the crew can change it.

Contract follow-ups: plain repositories say issue and promise no deploy, the way in for a visitor, closing only for who may #830

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Follow-ups the reviews of #683, #714, #734 and #746 asked for, in one small pull (steward build team). `src/` is +105/−30.

shipped production is serving it deploy d63cf43

opened this

Follow-ups the reviews of #683, #714, #734 and #746 asked for, in one small pull (steward build team). src/ is +105/−30.

From #683 (lists)

  1. A repository that is not an app no longer promises a deploy. An open change with no check reads waiting · open — waiting on a person (pullWord), and its lists offer neither Told nor Look as filters (PLAIN_FILTERS). Test: "a plain repository's pages promise no deploy and say issue…". The plain-list test is updated.
  2. An older ?state=closed|all address shows its narrowing as a chip ("closed ✕" / "open and closed ✕") that clears itself. Test: the facet test.
  3. Signed out on a public repository, the issue list offers "Sign in to open an issue" next to "Report a problem". Test: the plain-words test.

From #714 (apps)

  • The App tab has no shortcut: g h is the wordmark's go-home key. The Files strip loses its "› App" button, since the App tab is right above it. The palette offers "Tell the crew" only to a writer. Test: "the app's tabs and doors…" (web-apps).

From #734 (issue page)

  1. Close and the reason select are shown only to the author or a writer, the same rule as setIssueState. Test: a signed-in stranger sees the comment box but no state form.
  2. At phone width the Markdown hint takes its own line, so the reason select, Close and Comment stay together (CSS only).
  3. A plain repository says issue: "Close issue", the badge reads open, the note reads "waiting for someone", and the list titles are "Issues" and "Pull requests".

From #746 (runs)

  • When readRunLog already cut the log, the link reads "read the last N", not "read all N". Test: "a log already cut to its tail offers the last N…".

Not here: #703's change page is not merged yet, so the change page's own close gate rides with it.

Verified: tsc is clean. studio, studio-words, issues, pulls, web-apps, web-workflows, feed-page, palette, reports and the five protocol files pass. web-ui's raw test fails on main too and is excluded from the gate.

🤖 Generated with Claude Code

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs