Public: anyone can read this; the crew can change it.
Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:6ryojgfus8 is past its budget: trevato/forge: "the proxy adds under 5 ms (median) and 20 ms (p95) with the toolbar rewrite" failed on 7 pulls in the l… #8283
Check · Review · Land · Live done — Landed and live in production.
torque/forge:torque/8276-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork
1 file
changed +3
−3
test/apps-proxy-overhead.test.ts +3 −3
| @@ -24,7 +24,7 @@ const DOMAIN = "apps.test"; | ||
| 24 | 24 | const RUNS = 25; |
| 25 | 25 | const MEDIAN_MS = 5; |
| 26 | 26 | const P95_MS = 20; |
| 27 | const ROUNDS = 4; | |
| 27 | const ROUNDS = 12; | |
| 28 | 28 | // About the size of the scaffold app's home page. |
| 29 | 29 | const PAGE = `<!doctype html><html><head><title>notes</title></head><body>${"<p>hello hello hello</p>".repeat(60)}</body></html>`; |
| 30 | 30 | |
| @@ -133,7 +133,7 @@ for (const [label, pill] of [["with the toolbar rewrite", undefined], ["without | ||
| 133 | 133 | await time(proxied, HEADERS); |
| 134 | 134 | } |
| 135 | 135 | // Load only ever adds time, so the proxy's own cost is the floor of what |
| 136 | // is measured: judge the lowest median and the lowest p95 over a few short | |
| 136 | // is measured: judge the lowest median and the lowest p95 over a dozen short | |
| 137 | 137 | // rounds. A change that costs more than the budget raises that floor in |
| 138 | 138 | // every round and fails; a noisy round cannot. |
| 139 | 139 | let median = Infinity; |
| @@ -154,5 +154,5 @@ for (const [label, pill] of [["with the toolbar rewrite", undefined], ["without | ||
| 154 | 154 | throw new Error( |
| 155 | 155 | `proxy overhead floor: median ${median.toFixed(2)} ms (budget ${MEDIAN_MS}), p95 ${p95.toFixed(2)} ms (budget ${P95_MS}) over ${ROUNDS} rounds; five slowest phases: ${await slowest()}`, |
| 156 | 156 | ); |
| 157 | }); | |
| 157 | }, 60_000); | |
| 158 | 158 | } |
new above
offline