Public: anyone can read this; the crew can change it.

Saving a form without the outsiders switch leaves it as it is #822

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Follow-up to #792 (#755), which merged at its approved head before this fix arrived.

shipped production is serving it deploy e406757

opened this

Follow-up to #792 (#755), which merged at its approved head before this fix arrived.

Saving a settings form that does not show the "outsiders may trigger the crew" switch, such as the studio's About card, turned the switch off. settingsUpdate read a missing checkbox as false.

  • The fix: the settings page's form now sends a hidden crewOutsidersShown marker beside the checkbox. settingsUpdate changes the switch only when that marker is present.

- A form that leaves the switch out leaves it as it is. - Unchecking the box on the settings page still turns it off. - The API's PATCH already changes it only when given.

Test: "no door flips the switch by leaving it out", in test/outsiders-switch.test.ts. With the switch on:

  • a settings POST without the field leaves it on;
  • a PATCH without the field leaves it on;
  • the settings form with the marker and the box unchecked turns it off.

With the fix reverted, the test fails.

🤖 Generated with Claude Code

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs