b955130
@@ -47,11 +47,15 @@
export const NO_TEST_NAME = "(unnamed)";
 * the rest of its suite is not a gate, and a test keeps it existing.
 * Reserved names (#7809): each pull adding a top-level page without
 * reserving it ("keeper", "feed", "favicon.ico") failed it, main green.
 * OpenAPI coverage (#8140): each pull adding an /api/v1 route without its
 * row, or a route file without regenerating the index, failed it, main green.
 */
export const TREE_GATES: readonly string[] = [
  "design check: nothing added outside the system (#2678) > ",
  "no polling in src/web > ",
  "reserved names > every top-level page of the forge is a reserved name",
  "every registered /api/v1 route has an OpenAPI row or is listed as not yet described",
  "the gathered routes > the index is current: run `bun scripts/openapi-routes.ts`",
];
/** Whether a failing test's name is one of {@link TREE_GATES}'. */
@@ -94,6 +94,16 @@
describe("a red many pulls share", () => {
    expect(shared(red("i3", [other]))).toBe(true);
  });
  test("an /api/v1 route a pull left undescribed is that pull's own red, not the lane's (#8140)", () => {
    const gate = "every registered /api/v1 route has an OpenAPI row or is listed as not yet described";
    for (const i of ["i1", "i2", "i3"]) red(i, [gate]);
    expect(shared(red("i4", [gate]))).toBe(false);
    const index = "the gathered routes > the index is current: run `bun scripts/openapi-routes.ts`";
    for (const i of ["i1", "i2", "i3"]) red(i, [index]);
    expect(shared(red("i4", [index]))).toBe(false);
    expect(sharedTests(db)).toEqual([]);
  });
  test("every tree gate names a suite, or a test in it, that exists", () => {
    const names = new Set<string>();
    for (const f of new Glob("test/*.test.ts").scanSync(".")) for (const n of suiteNames(readFileSync(f, "utf8"))) names.add(n);
@@ -106,6 +116,7 @@
describe("a red many pulls share", () => {
    expect(names.has("B > u")).toBe(true);
    expect(names.has("B > t")).toBe(false);
    expect(names.has("A > u")).toBe(false);
    expect(suiteNames('test("top", () => {});\n').has("top")).toBe(true);
  });
  test("one pull red three times is its own red, not the lane's", () => {
@@ -275,7 +286,7 @@
function suiteNames(text: string): Set<string> {
  let suite: string | undefined;
  for (const m of text.matchAll(/\b(describe|test)\("((?:[^"\\]|\\.)*)"/g)) {
    if (m[1] === "describe") names.add(`${(suite = m[2])} > `);
    else if (suite !== undefined) names.add(`${suite} > ${m[2]}`);
    else names.add(suite === undefined ? m[2]! : `${suite} > ${m[2]}`);
  }
  return names;
}
		@@ -47,11 +47,15 @@ export const NO_TEST_NAME = "(unnamed)";
47	47	* the rest of its suite is not a gate, and a test keeps it existing.
48	48	* Reserved names (#7809): each pull adding a top-level page without
49	49	* reserving it ("keeper", "feed", "favicon.ico") failed it, main green.
	50	* OpenAPI coverage (#8140): each pull adding an /api/v1 route without its
	51	* row, or a route file without regenerating the index, failed it, main green.
50	52	*/
51	53	export const TREE_GATES: readonly string[] = [
52	54	"design check: nothing added outside the system (#2678) > ",
53	55	"no polling in src/web > ",
54	56	"reserved names > every top-level page of the forge is a reserved name",
	57	"every registered /api/v1 route has an OpenAPI row or is listed as not yet described",
	58	"the gathered routes > the index is current: run `bun scripts/openapi-routes.ts`",
55	59	];
56	60
57	61	/** Whether a failing test's name is one of {@link TREE_GATES}'. */
		@@ -94,6 +94,16 @@ describe("a red many pulls share", () => {
94	94	expect(shared(red("i3", [other]))).toBe(true);
95	95	});
96	96
	97	test("an /api/v1 route a pull left undescribed is that pull's own red, not the lane's (#8140)", () => {
	98	const gate = "every registered /api/v1 route has an OpenAPI row or is listed as not yet described";
	99	for (const i of ["i1", "i2", "i3"]) red(i, [gate]);
	100	expect(shared(red("i4", [gate]))).toBe(false);
	101	const index = "the gathered routes > the index is current: run `bun scripts/openapi-routes.ts`";
	102	for (const i of ["i1", "i2", "i3"]) red(i, [index]);
	103	expect(shared(red("i4", [index]))).toBe(false);
	104	expect(sharedTests(db)).toEqual([]);
	105	});
	106
97	107	test("every tree gate names a suite, or a test in it, that exists", () => {
98	108	const names = new Set<string>();
99	109	for (const f of new Glob("test/*.test.ts").scanSync(".")) for (const n of suiteNames(readFileSync(f, "utf8"))) names.add(n);
		@@ -106,6 +116,7 @@ describe("a red many pulls share", () => {
106	116	expect(names.has("B > u")).toBe(true);
107	117	expect(names.has("B > t")).toBe(false);
108	118	expect(names.has("A > u")).toBe(false);
	119	expect(suiteNames('test("top", () => {});\n').has("top")).toBe(true);
109	120	});
110	121
111	122	test("one pull red three times is its own red, not the lane's", () => {
		@@ -275,7 +286,7 @@ function suiteNames(text: string): Set<string> {
275	286	let suite: string \| undefined;
276	287	for (const m of text.matchAll(/\b(describe\|test)\("((?:[^"\\]\|\\.)*)"/g)) {
277	288	if (m[1] === "describe") names.add(`${(suite = m[2])} > `);
278		else if (suite !== undefined) names.add(`${suite} > ${m[2]}`);
	289	else names.add(suite === undefined ? m[2]! : `${suite} > ${m[2]}`);
279	290	}
280	291	return names;
281	292	}