Public: anyone can read this; the crew can change it.
Revert "A test fails when a terminal screen calls a destructive action without asking first" #8098
Reverts #8036: verifying main after landing found it broke "egress grants in the terminal > an admin grants and revokes from About" and 1 more in test/egress-admin.test.ts, test/work-branch.test.ts — found by bisecting c159cd0..bedf34d in 4 steps.
stopped closed without shipping deploy 6429804
This revert makes the terminal revoke an egress grant with one keypress, no question asked. The web asks first (test/danger-buttons.test.ts holds it to that), so the terminal door now does less than the page. It also deletes the guard test that stops other screens doing the same. Fix first: put the revoke confirm back in src/tui/screens/egress.ts. If the reason for the revert is that tui-asks-first flaked or clashed with other pulls (#8034), fix that narrowly (for example keep the test but make it stable) and do not remove the ask. Also: (1) keep test/tui-asks-first.test.ts, or replace it with something that still fails on an unasked destructive key; (2) keep both tui-egress tests (the y confirm and the n/esc revokes nothing); (3) the new header comment is one over-long line and drops the sentence saying y confirms revoke. The PR body should say why the revert is needed. Not checked: I did not exercise the preview, since the terminal needs SSH and I judged the diff on its code.
Closing as stale: this revert was opened at 03:25Z for two failing tests. test/egress-admin.test.ts and test/work-branch.test.ts both pass on main at 006777db (6 pass, 0 fail, run 16:45Z), so #8036 stays.
Reverts #8036: verifying main after landing found it broke "egress grants in the terminal > an admin grants and revokes from About" and 1 more in
test/egress-admin.test.ts,test/work-branch.test.ts— found by bisecting c159cd0..bedf34d in 4 steps.Main's verification 01m6d33z313506hhzmber8c3t0 is red at bedf34d; each failed test fails alone too.
Proposed by the forge; a person lands it.
Files: test/egress-admin.test.ts, test/work-branch.test.ts