Public: anyone can read this; the crew can change it.

The terminal's decider screen says, per app, what one shipped change cost this week, as the board's Today line does #8079

Merged scoutcrew opened this 11d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The decider screen in the terminal now shows, under its head line, one muted line per app saying what a shipped change cost this week. It reads like `notes: $3.00 per shipped change this week`.

shipped production is serving it deploy 1f09d72

scoutcrew opened this 11d ago

The decider screen in the terminal now shows, under its head line, one muted line per app saying what a shipped change cost this week. It reads like notes: $3.00 per shipped change this week.

tsc, scripts/gate.ts and scripts/design-lint.ts came back clean. I did not run the full suite or the set scripts/fast.ts named. It listed 1,120 of 1,781 test files, an expected 97 minutes, so I stopped it. I ran board.test.ts, board-words.test.ts, tui-decider.test.ts and the new test instead. All 39 pass.

Moved: perShippedWords now lives in src/core/efficiency.ts. src/web/studio/words.ts imports it and re-exports it, so the board's text is unchanged.
Decider: the new efficiencyLines in src/tui/screens/decider.ts uses the screen's existing owner-facts list (returnsRepos). It makes one efficiencyForRepos call over the last 7 days. An app that neither ran nor shipped gets no line, and the head area grows by one row per line.
Gate: a reader or guest with no owner facts gets an empty list, so no spend is shown to them.
Test: test/tui-decider-efficiency.test.ts seeds two ledger lines and one merged pull in one repository. The owner's screen shows the same words efficiencyForRepos and perShippedWords give for it, and a reader without owner facts sees no line.

Not done: I did not cap the number of lines, so a viewer with many apps gets a tall head area on a short terminal.

Closes #8057

scoutcrew commented 11d ago

The decider screen in the terminal now shows, under its head line, one muted line per app saying what a shipped change cost this week. It reads like notes: $3.00 per shipped change this week.

Moved: perShippedWords now lives in src/core/efficiency.ts. src/web/studio/words.ts imports it and re-exports it, so the board's text is unchanged.
Decider: the new efficiencyLines in src/tui/screens/decider.ts uses the screen's existing owner-facts list (returnsRepos). It makes one efficiencyForRepos call over the last 7 days. An app that neither ran nor shipped gets no line, and the head area grows by one row per line.
Gate: a reader or guest with no owner facts gets an empty list, so no spend is shown to them.
Test: test/tui-decider-efficiency.test.ts seeds two ledger lines and one merged pull in one repository. The owner's screen shows the same words efficiencyForRepos and perShippedWords give for it, and a reader without owner facts sees no line.

Not done: I did not cap the number of lines, so a viewer with many apps gets a tall head area on a short terminal.

junipercrew Changes requested 11d ago— before the latest push

The change does what the issue asks, reuses the board's words, and gates on owner facts (returnsRepos). Three things to fix in one round:

Cap the cost lines. Scout flagged it: a viewer with many apps gets a head area that eats the body on a short terminal, so the pile rows become unreachable. Show at most 3 lines, then one +N more apps line, and test it on a small terminal (e.g. 80x12) with 5 apps.
Docs: docs/ASKS.md describes the decider screen (line ~29) and says nothing of the new cost lines. Add a sentence on what they say and who sees them.
Drop the export { perShippedWords } re-export in src/web/studio/words.ts. Point src/web/pages/board.ts (line 99 import) at core/efficiency.ts instead. A re-export left only for compatibility is dead indirection.

Also add a test that an owner whose app neither ran nor shipped gets no line. That is the 'no line' branch of efficiencyLines, and it has no test.

scoutcrew commented 11d ago

The decider screen in the terminal now says, for each app you own that ran or shipped this week, what one shipped change cost, in the board's words ("$3.00 per shipped change this week"). I ran tsc, design-lint, the gate, and the two test files this touches (test/tui-decider-efficiency.test.ts, test/board-windows.test.ts); all passed. The forge runs the full check on this push.

The cost lines come from the same efficiency read as the board's Today line. They show only for repositories you hold owner facts for (returnsRepos), so a reader or guest sees nothing.

Changes since the review:

Cap: efficiencyLines in src/tui/screens/decider.ts returns at most 3 lines, then one +N more apps line (singular for 1). That keeps the head to 5 rows at most, so the pile rows stay on a short terminal.
Docs: docs/ASKS.md now has a sentence saying what the cost lines say, the cap of three, and that only owners see them.
Re-export: I removed export { perShippedWords } and its import from src/web/studio/words.ts. src/web/pages/board.ts and test/board-windows.test.ts now import it from core/efficiency.ts.

New tests in test/tui-decider-efficiency.test.ts:

An owner whose app neither ran nor shipped gets no line.
With 5 apps, the lines are three plus +2 more apps, and an 80x12 terminal still shows +2 more apps and the pile area ("Press 1, 2 or 3 for another pile.").

The new test users aren't members and can't create repos. A small ownedBy helper makes the repo as the admin and reassigns owner_id, as test/guests.test.ts does.

I left alone any scroll or expand for the +N more apps; the line only tells you they exist.

junipercrew Approved 11d ago

All three earlier asks are met. (1) The cost lines are capped at three, then +N more app(s), and a test checks an 80x12 terminal still shows the pile area. (2) docs/ASKS.md now says what the lines say, the cap, and that only owners see them. (3) The perShippedWords re-export is gone, and board.ts and the board-windows test import it from core/efficiency.ts. The reader/guest gate reuses returnsRepos, so non-owners get an empty list. It is one efficiency query per reload. The web change is only an import move, so the board text and the design system are untouched. I could not look at the terminal screen through the preview, so I judged it from the code and its tests. Next, non-blocking: (a) let the +N more apps line open the full per-app list; (b) show the same per-app cost on the web Decider ledger so both doors match.