Public: anyone can read this; the crew can change it.

The terminal's milestones screen shows each milestone's pace: issues closed per day as a sparkline and when it lands at this pace #8077

Parked opened this
Closed without merging

The terminal's milestones screen now draws each milestone's pace as a muted line under its row. The line is a sparkline of closedPerDay (▁–█, scaled to that milestone's max) followed by pace.line word for word.

Notes

stopped parked by the crew deploy 2196373

opened this

The terminal's milestones screen now draws each milestone's pace as a muted line under its row. The line is a sparkline of closedPerDay (▁–█, scaled to that milestone's max) followed by pace.line word for word. The pace tests, the existing limbs tests, test/tui-asks-first.test.ts, tsc --noEmit and scripts/gate.ts all pass here. I did not run the full suite; the forge's check does.

What changed (src/tui/screens/limbs.ts)

  • The screen read each milestone's pace from the Plan it already loads, and showed the sentence only for the row under the cursor, in the foot. That foot line is gone. The pace now comes from the same Plan, with no second readPlan call.
  • Because a row can now take two lines, I replaced the shared drawList and hitList here with a local draw and click handler.
    • The cursor stays in view as before.
    • Clicks still map to the right milestone, so a click on a pace line selects its row.
    • The scrollbar and wheel work as before.
  • Raise and Lower keys, the key list, the confirm flows and the spend and re-plan blocks are unchanged.
  • On a narrow terminal the sparkline goes first and the sentence stays. The sparkline drops when it plus the sentence would fill the whole row width, so the sentence never touches the scrollbar. At the 40-column minimum, "on pace for <date>" shows without the sparkline.
  • An empty pace.line draws no line.

Tests (test/tui-limbs-pace.test.ts)

  • A milestone with leaves closed on three different days shows the same pace.line the page shows, plus a sparkline of PACE_DAYS cells.
  • A narrow terminal shows the sentence without the sparkline.
  • A milestone with no leaves, and an empty pace line, gets no pace line. I only observed that this milestone has no sparkline under its row; I never checked that its pace.line really is empty. If it isn't empty, the test just checks that the sentence appears.

Not done

  • A milestone with leaves but nothing closed gets "no movement in 7 days", not a blank. paceOf returns an empty line only for an empty or deferred milestone, so a line for a milestone with nothing closed follows what the page does. I did not change paceOf.

To try it, open Milestones in a repository from the palette in the terminal.

🤖 Generated with Claude Code

Closes #8058

3 earlier comments
commented

The terminal's milestones screen now draws each milestone's pace as a muted line under its row. The line is a sparkline of closedPerDay (▁–█, scaled to that milestone's max) followed by pace.line word for word. The pace tests, the existing limbs tests, test/tui-asks-first.test.ts, tsc --noEmit and scripts/gate.ts all pass here. I did not run the full suite; the forge's check does.

What changed (src/tui/screens/limbs.ts)

  • The screen read each milestone's pace from the Plan it already loads, and showed the sentence only for the row under the cursor, in the foot. That foot line is gone. The pace now comes from the same Plan, with no second readPlan call.
  • Because a row can now take two lines, I replaced the shared drawList and hitList here with a local draw and click handler.
    • The cursor stays in view as before.
    • Clicks still map to the right milestone, so a click on a pace line selects its row.
    • The scrollbar and wheel work as before.
  • Raise and Lower keys, the key list, the confirm flows and the spend and re-plan blocks are unchanged.
  • On a narrow terminal the sparkline goes first and the sentence stays. The sparkline drops when it plus the sentence would fill the whole row width, so the sentence never touches the scrollbar. At the 40-column minimum, "on pace for <date>" shows without the sparkline.
  • An empty pace.line draws no line.

Tests (test/tui-limbs-pace.test.ts)

  • A milestone with leaves closed on three different days shows the same pace.line the page shows, plus a sparkline of PACE_DAYS cells.
  • A narrow terminal shows the sentence without the sparkline.
  • A milestone with no leaves, and an empty pace line, gets no pace line. I only observed that this milestone has no sparkline under its row; I never checked that its pace.line really is empty. If it isn't empty, the test just checks that the sentence appears.

Not done

  • A milestone with leaves but nothing closed gets "no movement in 7 days", not a blank. paceOf returns an empty line only for an empty or deferred milestone, so a line for a milestone with nothing closed follows what the page does. I did not change paceOf.

To try it, open Milestones in a repository from the palette in the terminal.

🤖 Generated with Claude Code

commented

I found no cause in my change, so I pushed an empty commit to re-run the check. The three failures are in test/egress-admin.test.ts and test/tui-migrate.test.ts, and neither file touches the limbs screen.

  • Egress (2 tests): an admin grants and revokes from About times out at 5 s in this sandbox, and the second egress test then fails on the grant it left behind. They fail the same way on an untouched main checkout. The check log says they "fail only beside others", with test/webvitals.test.ts as shard-mate, so they are order- or load-dependent.
  • Migrate (1 test): the form offers leave by default; choosing archive… passed on all three local runs of test/tui-migrate.test.ts, so I couldn't reproduce it.

If the check fails on them again, someone should look at them separately: a shard-order or timing problem in those two files, not in this pull. The pull itself is unchanged, apart from the empty commit.

commented

I couldn't reproduce these failures, so I pushed another empty commit to re-run the check.

  • What failed: notes from the app, in the terminal (2 tests) and the terminal lays out for the terminal it is in (1 test). They are in test/tui-notes.test.ts and test/tui-size.test.ts.
  • Locally: all 22 tests in those two files pass, and neither file touches the limbs screen.
  • In the check: the log shows shard 15 killed after 16 s, running test/waves.test.ts in the same run, so the shards were under heavy load.
  • What the pull changes: only src/tui/screens/limbs.ts and test/tui-limbs-pace.test.ts.
  • Earlier push: the failures last time were also in unrelated files (egress and migrate).

If this run fails again on different unrelated tests, the cause is the check's load, not this pull.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs