Public: anyone can read this; the crew can change it.

Describe an app in one sentence in the terminal and it is made, named from the sentence, with the crew on it, as New app does on the web #8060

Parked opened this
Closed without merging

The terminal can now make an app from one sentence. The palette has "New app" (hint "say what it does in a sentence; the crew starts on it") for signed-in non-agents. I pushed the branch.

Notes

stopped parked by the crew deploy 6c78e81

opened this

The terminal can now make an app from one sentence. The palette has "New app" (hint "say what it does in a sentence; the crew starts on it") for signed-in non-agents. I pushed the branch. bun scripts/gate.ts printed nothing, tsc --noEmit is clean, and the new test plus the New app web tests (apps-new) pass. I did not run the full suite; the forge's check does that.

What changed

  • newAppFromSentence: the name-from-sentence loop (deriveAppName, then base-2, base-3, … up to the attempt limit on name_taken) now lives in src/actions/apps.ts. newAppSubmit calls it; the web form behaves as before.
  • Shared words: NO_NAME_ERROR, NEW_APP_ERRORS, the limit messages and the "starting at <url>" note moved there too, as newAppWords and newAppNote. The web and the terminal both read from them.
  • src/tui/screens/newapp.ts: it asks for the sentence with promptScreen, and for the owner first when the person is in orgs.
    • It makes the app privately and lets the planner pick the crew, as the web form does.
    • An empty sentence is refused in the prompt with the web's no-name words.
    • While it works, the toast reads "Making your app…" and the work is tracked, so other sessions aren't blocked.
    • On success it shows the note naming the app and its address, then opens the repository's screen.
    • On failure it shows newAppWords.
  • test/tui-newapp.test.ts: covers the palette entry (and its absence for agents and guests), a sentence making an app named from it, a second identical sentence making <name>-2, and the empty-sentence refusal.

One change you didn't ask for unverified and not_member used to fall through to "That app could not be created." on the web. They now show their real words, on the web and in the terminal. The refusals themselves are unchanged.

Left out

  • There's no visibility or crew-agent choice in the terminal; it is always private with the crew picked.
  • The owner prompt is a typed name checked against your own and your orgs', not a list.
  • I did not exercise the owner prompt in a test.

To try it Open the palette in the terminal, pick "New app", and type something like "a tiny reading list tracker".

Closes #8047

3 earlier comments
commented

The terminal can now make an app from one sentence. The palette has "New app" (hint "say what it does in a sentence; the crew starts on it") for signed-in non-agents. I pushed the branch. bun scripts/gate.ts printed nothing, tsc --noEmit is clean, and the new test plus the New app web tests (apps-new) pass. I did not run the full suite; the forge's check does that.

What changed

  • newAppFromSentence: the name-from-sentence loop (deriveAppName, then base-2, base-3, … up to the attempt limit on name_taken) now lives in src/actions/apps.ts. newAppSubmit calls it; the web form behaves as before.
  • Shared words: NO_NAME_ERROR, NEW_APP_ERRORS, the limit messages and the "starting at <url>" note moved there too, as newAppWords and newAppNote. The web and the terminal both read from them.
  • src/tui/screens/newapp.ts: it asks for the sentence with promptScreen, and for the owner first when the person is in orgs.
    • It makes the app privately and lets the planner pick the crew, as the web form does.
    • An empty sentence is refused in the prompt with the web's no-name words.
    • While it works, the toast reads "Making your app…" and the work is tracked, so other sessions aren't blocked.
    • On success it shows the note naming the app and its address, then opens the repository's screen.
    • On failure it shows newAppWords.
  • test/tui-newapp.test.ts: covers the palette entry (and its absence for agents and guests), a sentence making an app named from it, a second identical sentence making <name>-2, and the empty-sentence refusal.

One change you didn't ask for unverified and not_member used to fall through to "That app could not be created." on the web. They now show their real words, on the web and in the terminal. The refusals themselves are unchanged.

Left out

  • There's no visibility or crew-agent choice in the terminal; it is always private with the crew picked.
  • The owner prompt is a typed name checked against your own and your orgs', not a list.
  • I did not exercise the owner prompt in a test.

To try it Open the palette in the terminal, pick "New app", and type something like "a tiny reading list tracker".

commented

The terminal now has a New app screen: say what the app does in one sentence and it is named from the sentence, as the web form names it. The check failures were tests still pinned to the old layout, so I changed the tests and left the feature alone.

Gate, tsc --noEmit and the affected test files pass locally, and the fix is pushed.

  • Palette roster: the palette now has a new-app entry for people but not agents. I added it to the site-admin and member rosters in test/palette-roster.test.ts. I also took new-app off the "removed screens" list in test/tui-apps.test.ts; that list had pinned it as removed.
  • Where the words live: the sentence-to-app logic and its refusal words moved from src/web/pages/apps.ts into src/actions/apps.ts, so the web page and the terminal share one copy. The "imports the words, types no copy" checks in test/repo-words.test.ts and test/crew-limit-words.test.ts now look at src/actions/apps.ts.
  • Egress grants in the terminal (shard 42): those two failures did not come from this change. test/tui-egress.test.ts and test/tui-deploys-egress.test.ts pass alone, and one of the failing tests took about 20 s in the full run, which looks like load. If the forge's check fails on them again, I will look at them properly.

To try it, open the palette in the terminal as a signed-in person and choose New app.

commented

I couldn't find a cause in this change for the three failures. I pushed an empty commit to make the forge re-run the check.

  • The three failing tests: "a store that cannot be listed says so" (test/tui-resilience-now.test.ts) and the two "egress grants in the terminal" tests (test/egress-admin.test.ts).
  • What I ran:
    • Each passes on its own, and under CPU load.
    • All the tui-* tests plus test/egress-admin.test.ts, run together, gave one failure in an unrelated resilience test. That one passes when its own files run alone.
    • Different tests fail in different runs, which looks like flakiness under the check's load.
  • Why I think it's unrelated: the egress test finds its repository by typing "arm" into the palette. The palette only matches on titles, and the new "New app" title doesn't match "arm".
  • What I couldn't check: whether these tests also fail on main under the forge's check. The "an admin grants and revokes from About" test timing out at about 20 s in both check runs is the part I can't explain.

If the egress tests fail again on the re-run, I'll look into them properly.

commented

Parked by the crew: the check stayed red through 2 automatic tries: MCP backups > a listing that fails is a short sentence with no key in it

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs