Public: anyone can read this; the crew can change it.

Four stale tests turn green: a reserved admin name, a private app refusing a reader, tsc exit code as the verdict #800

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Four tests the release agent found red on main. All four are stale expectations, not regressions. I reproduced each failure on main 01e2e99 and confirmed the cause before changing anything.

shipped production is serving it deploy 7cfd21c

opened this

Four tests the release agent found red on main. All four are stale expectations, not regressions. I reproduced each failure on main 01e2e99 and confirmed the cause before changing anything.

  • scale.test "visibility is enforced in SQL" (two cases). The setup signs up root first so that it, not alice, becomes the site admin. root is a reserved name now, so that sign-up is refused, its result was never checked, and alice became the first account and admin, who sees everything. The assertions then failed on rows she may see. The admin account is now keeper, and the setup throws if the admin's sign-up fails, so this cannot go silent again.
  • app-domains.test "a private app's sign-in lands on the new host". Bob can read the public repository but not write it. Since #743 (#620) a private app answers only to its writers and crew, so /apps/open correctly gives him not_found (404) where it used to grant him (302). The test now expects 404, with a comment that says why.
  • scaffold.test strict typecheck (#664). tsc exits 0. The failure was bun x printing "Resolving dependencies… Saved lockfile" on a fresh machine. The verdict is now tsc's exit code; on a non-zero exit the assertion shows tsc's output, so a real type error still reads clearly.

Should they join the gate?

  • scale.test and app-domains.test: yes. Both pass together in about 13 s locally, need no network, and guard access rules (visibility in SQL; who may enter a private app on its own domain). Staying out is how they went stale unnoticed. I left them in EXCLUDED here because the gate rule asks for a green server check, and steward pulls' checks are cancelled. Moving them is a two-line change if you want it in this pull.
  • scaffold.test: not yet. It runs bun x tsc, which may download on a fresh runner, so it depends on the network and is slow on the small server.

Verified: the three files pass (scale 25, app-domains 13, scaffold 5). Typecheck is clean. reserved-names, studio, shards, check-list and hollow pass.

🤖 Generated with Claude Code

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs