Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:l4srihhymu was degraded 66 minutes today: trevato/forge: "the decision ledger > stop is not the last word on a red check: the environment's fault runs it again, … #7928

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

mason/forge:mason/7904-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 1 thread · 1 unresolved

  • Merged. mason/7904-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as 8a16183.

Review

Sign in to review this change.
1 file changed +3 −1
test/ledger.test.ts +3 −1
@@ -360,7 +360,9 @@ describe("the decision ledger", () => {
360360 } finally {
361361 delete script["cause"];
362362 }
363 });
363 // Two git writes and an open pull: the verdict is the code's, so the clock

Nit: this comment explains the test timeout but sits inside the body after the finally. Put it above the test( line, or drop it if the timeout argument is self-explanatory next to line 113.

364 // on a loaded check machine must not be the test's.
365 }, 30_000);
364366
365367 test("conflicts come first: a green pull that no longer merges gets a conflict run before anyone decides", async () => {
366368 const branch = await commitToBranch(app, alice, repo, {

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs