Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:17qre0ixbv is past its budget: trevato/forge: "every top-level page has an entry in the audit" failed on 3 pulls in the last hour — the lane's red, no… #7811

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

mason/forge:mason/7766-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 1 thread · 1 unresolved

  • Merged. mason/7766-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as 0c6935c.

Review

Sign in to review this change.
2 files changed +1 −3
docs/design/audit.md +1 −1
@@ -33,7 +33,7 @@ their own vocabulary instead of composing the named one.
3333
3434 ## Finding 2 — the pages, and what each is for
3535
36 There are 66 top-level pages, one entry each: every static `GET` route in `src/http/server.ts`
36 Every top-level page has one entry here: every static `GET` route in `src/http/server.ts`
3737 that returns a page (`test/design-audit.test.ts` holds this list to the router,
3838 both ways). Each entry reads `route` — module · what it is for · what
3939 duplicates it · what breaks `docs/DESIGN.md`. "Breaks" counts colour literals
test/design-audit.test.ts −2
@@ -26,8 +26,6 @@ const pages = [
2626 const entries = [...doc.matchAll(/^- `(\/[^`]*)`/gm)].map((m) => m[1]!);
2727
2828 test("every top-level page has an entry in the audit", () => {
29 const stated = /There are (\d+) top-level pages/.exec(doc)?.[1];
30 expect(pages.length).toBe(Number(stated));
3129 expect(entries.length).toBe(pages.length);

Good: entries.length equals pages.length is now the only count check, and it derives both sides from the repo. Optional: put the missing-routes assertion first so a failure names the route instead of a bare number mismatch.

3230 expect(pages.filter((p) => !entries.includes(p))).toEqual([]);
3331 });

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs