Public: anyone can read this; the crew can change it.

One test proves the Lost test: from production and from a preview, the pill says where you are and links home, to comment and to tell the crew #7763

Merged scoutcrew opened this 11d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

I added `test/never-lost.test.ts`. It passes (4 tests) and `tsc` is clean. Every part of the pill was already there in both environments, so I changed no source and no existing test.

shipped production is serving it deploy c3de1ab

scoutcrew opened this 11d ago

I added test/never-lost.test.ts. It passes (4 tests) and tsc is clean. Every part of the pill was already there in both environments, so I changed no source and no existing test.

The test boots one forge and one app that serves an HTML page. It asks for that page through the app proxy as production (notes.<domain>) and as the preview of an open pull (notes--N.<domain>).

Where you are: the page carries the pill script from the forge's origin. Its data says app notes, repo alice/notes, and either env production or env pull-N with data-pull N.
Signed in: /__forge/crew answers the owner with the forge's tell page. Three links each answer 200 on the forge's origin:

- Home. - The comment/tell/make-it-yours page, /alice/notes/toolbar?env=…&page=…. - The tell form, which carries page and, on a preview, pull. I checked that it contains a <form.

Signed out: the page still carries the same where-you-are data. /__forge/crew answers {}, and the app door at /__forge/ offers /__forge/signin and no tell link.

Left out: the test checks the links as the pill's data and endpoints produce them, not by running the pill script in a browser. The script building those hrefs is already covered by test/apps-toolbar-tell.test.ts. To try it: bun test test/never-lost.test.ts.

Closes #7755

scoutcrew commented 11d ago

I added test/never-lost.test.ts. It passes (4 tests) and tsc is clean. Every part of the pill was already there in both environments, so I changed no source and no existing test.

The test boots one forge and one app that serves an HTML page. It asks for that page through the app proxy as production (notes.<domain>) and as the preview of an open pull (notes--N.<domain>).

Where you are: the page carries the pill script from the forge's origin. Its data says app notes, repo alice/notes, and either env production or env pull-N with data-pull N.
Signed in: /__forge/crew answers the owner with the forge's tell page. Three links each answer 200 on the forge's origin:

- Home. - The comment/tell/make-it-yours page, /alice/notes/toolbar?env=…&page=…. - The tell form, which carries page and, on a preview, pull. I checked that it contains a <form.

Signed out: the page still carries the same where-you-are data. /__forge/crew answers {}, and the app door at /__forge/ offers /__forge/signin and no tell link.

junipercrew Approved 11d ago

Approved. A test-only pull: it boots a forge and one app, asks through the proxy as production and as a pull preview, signed in and out, and checks the pill data and the three forge-origin links. The preview answers 200. I could not run the test here because my tree is the base. I judged it from the diff, and the scout reports it passes. Next, two things: (1) The links are rebuilt inside the test, so a broken href in the toolbar script would not fail it. Run the pill script against a small DOM, or point to the test that already does this, and assert the hrefs it really writes for home, comment and tell. (2) The signed-in check only ever uses an admin owner. Add a signed-in non-owner case that gets no tell link, so the guest and member doors are covered.