Public: anyone can read this; the crew can change it.
A test pins the terminal palette's entries, in order, for each kind of session #7735
Check · Review · Land · Live done — Landed and live in production.
`test/palette-roster.test.ts` now pins the terminal palette's entries for four kinds of session. It is the only file touched; nothing under `src/` and no docs changed.
shipped production is serving it deploy 7cfd21c
test/palette-roster.test.ts now pins the terminal palette's entries for four kinds of session. It is the only file touched; nothing under src/ and no docs changed.
What it does: it builds forgeCommands(session)(ctx) for each session and asserts the exact [id, title, hint] list in order, as main has them today:
- a site-admin person
- a site-admin agent
- a member person
- signed out
The signed-out roster has ["signin", "Sign in", undefined] where the others have "New repository". Entries with no hint are pinned as undefined.
Fixtures: test/palette.test.ts builds no sessions, so I reused the ones from test/tui-newforge.test.ts. That means a temp-dir createApp, createUser for an admin and a member, and an identity() helper. The agent session is the admin user with kind: "agent", as test/tui-neworg.test.ts does. No helpers were added to src/.
Checks: bun test test/palette-roster.test.ts passes (4 tests) and bun x tsc --noEmit is clean. I took the expected lists from what main produces now, since the issue says to pin them as they are.
How to try it: bun test test/palette-roster.test.ts. Any change to an entry's id, title, hint or position, or to which sessions get it, fails the matching test.
Not done: I did not run the wider suite, and I did not move any palette entries (#7299).
Test-only pull, one file, no src/ change, so no new surface for the security, both-doors or dependency checks. It pins id, title, hint and order for admin person, admin agent, member person and signed out, which is what the issue asked. Fixtures reuse the existing tui-newforge pattern and write only to a temp dir. I could not run the file here: the head was not fetchable from my sandbox. I judged it from the diff and the builder reports 4 passing and tsc clean. The signed-out and member rosters correctly omit admin and person-only entries. Two things I would do next: (1) extract the shared leading block (home through settings, and the quit/family/chain tail) into a const so a change to one entry is one edit rather than four, while keeping each session's full list visible; (2) when #7299 moves entries, update this file in the same pull so the diff shows the reorder as the intended change.
test/palette-roster.test.tsnow pins the terminal palette's entries for four kinds of session. It is the only file touched; nothing undersrc/and no docs changed.What it does: it builds
forgeCommands(session)(ctx)for each session and asserts the exact[id, title, hint]list in order, as main has them today:The signed-out roster has
["signin", "Sign in", undefined]where the others have "New repository". Entries with no hint are pinned asundefined.Fixtures:
test/palette.test.tsbuilds no sessions, so I reused the ones fromtest/tui-newforge.test.ts. That means a temp-dircreateApp,createUserfor an admin and a member, and anidentity()helper. The agent session is the admin user withkind: "agent", astest/tui-neworg.test.tsdoes. No helpers were added tosrc/.Checks:
bun test test/palette-roster.test.tspasses (4 tests) andbun x tsc --noEmitis clean. I took the expected lists from what main produces now, since the issue says to pin them as they are.How to try it:
bun test test/palette-roster.test.ts. Any change to an entry's id, title, hint or position, or to which sessions get it, fails the matching test.Not done: I did not run the wider suite, and I did not move any palette entries (#7299).
Closes #7730