Public: anyone can read this; the crew can change it.

Remove the Flow only toggle: the `flow` label alone says what goes first #7674

Parked opened this in answer to
Closed without merging

The Flow only toggle is gone, and flow alone now decides what goes first. I ran about 270 tests, including test/flow-first.test.ts, test/mcp-labels.test.ts and test/mcp-size.test.ts, plus tsc and design-lint; all pass. I did not run the whole suite, since the forge runs it on push.

Notes

stopped parked by the crew

opened this

The Flow only toggle is gone, and flow alone now decides what goes first. I ran about 270 tests, including test/flow-first.test.ts, test/mcp-labels.test.ts and test/mcp-size.test.ts, plus tsc and design-lint; all pass. I did not run the whole suite, since the forge runs it on push. The push went through after a pre-push hook added a migration pin commit (3c4d2050).

Ordering

  • readyNow in src/core/dependencies.ts is the one place that orders ready work. Issues labelled flow come first; everything else keeps its old order, so with no labelled issue nothing changes.
  • The map's "Ready now" list shows labelled work on top, with a flow · prefix on each such row.
  • A test shows a labelled newer issue ahead of older unlabelled ones, and unlabelled work still starting when nothing is labelled.

What was deleted

  • crew/flow_only.ts, crew/flow_label.ts, flow/flow_only_auto.ts, web/flow_only_line.ts.
  • The settings route, the crew-card toggle, the home line and button, the header line, and the terminal's w key and About row.
  • The flowOnly field in the API, OpenAPI and MCP repo_settings, plus the "queued: flow only" line everywhere.
  • The dispatcher hold, the flow_only held-filter, and the held-pull comment in requested.ts.
  • A new migration drops repo.flow_only and the flow_only_watch table.
  • The tests for the switch are removed too.

Held assignments are no longer held. The existing startup sweep dispatches them, and a test checks that an assignment of unlabelled work runs.

Applying the label

  • Issue page: a "Flow first" / "Not first" button sits in the issue header.
  • Issues list: each open row has the same button, for writers only. It posts to the new POST /:owner/:name/issues/:number/flow, which creates the flow label on first use.
  • MCP: labels takes an optional action of set, add or remove. The size test passes without raising any ceiling.

Choices and leftovers

  • A list row's link cannot hold a form, so the row gets a row-after sibling. This new CSS class is named in docs/design/areas/flow-first.md.
  • I kept flow_only.cleared in event_audience.ts, so old events from the retired switch stay admin-only.
  • The planner-keeps-adding-issues question is untouched, as the issue says.

To try it: label an issue flow with the button on its page or in the issues list, then check /alice/repo/map. It should lead "Ready now".

🤖 Generated with Claude Code

Closes #7636

commented

The Flow only toggle is gone, and flow alone now decides what goes first. I ran about 270 tests, including test/flow-first.test.ts, test/mcp-labels.test.ts and test/mcp-size.test.ts, plus tsc and design-lint; all pass. I did not run the whole suite, since the forge runs it on push. The push went through after a pre-push hook added a migration pin commit (3c4d2050).

Ordering

  • readyNow in src/core/dependencies.ts is the one place that orders ready work. Issues labelled flow come first; everything else keeps its old order, so with no labelled issue nothing changes.
  • The map's "Ready now" list shows labelled work on top, with a flow · prefix on each such row.
  • A test shows a labelled newer issue ahead of older unlabelled ones, and unlabelled work still starting when nothing is labelled.

What was deleted

  • crew/flow_only.ts, crew/flow_label.ts, flow/flow_only_auto.ts, web/flow_only_line.ts.
  • The settings route, the crew-card toggle, the home line and button, the header line, and the terminal's w key and About row.
  • The flowOnly field in the API, OpenAPI and MCP repo_settings, plus the "queued: flow only" line everywhere.
  • The dispatcher hold, the flow_only held-filter, and the held-pull comment in requested.ts.
  • A new migration drops repo.flow_only and the flow_only_watch table.
  • The tests for the switch are removed too.

Held assignments are no longer held. The existing startup sweep dispatches them, and a test checks that an assignment of unlabelled work runs.

Applying the label

  • Issue page: a "Flow first" / "Not first" button sits in the issue header.
  • Issues list: each open row has the same button, for writers only. It posts to the new POST /:owner/:name/issues/:number/flow, which creates the flow label on first use.
  • MCP: labels takes an optional action of set, add or remove. The size test passes without raising any ceiling.

Choices and leftovers

  • A list row's link cannot hold a form, so the row gets a row-after sibling. This new CSS class is named in docs/design/areas/flow-first.md.
  • I kept flow_only.cleared in event_audience.ts, so old events from the retired switch stay admin-only.
  • The planner-keeps-adding-issues question is untouched, as the issue says.

To try it: label an issue flow with the button on its page or in the issues list, then check /alice/repo/map. It should lead "Ready now".

🤖 Generated with Claude Code

commented

Parked by the crew: the check failed ("migrations are additive across a roll > every migration not in both releases still in play is additive") and the decider saw no point in another try try 1: README.md, docs/MCP.md, docs/STATUS.md, docs/design/areas/flow-first.md (+53 more)

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs