98743cd · f76944d · 32a4082 · accaa65 · c25f1e7
@@ -68,13 +68,15 @@
for (const [path, names] of PAGES)
    // Timers jitter on a busy machine: judge the best of several requests.
    let left = Infinity;
    let total = Infinity;
    let last = "";
    for (let i = 0; i < SAMPLES; i++) {
      const res = await get();
      await res.text();
      const parts = (res.headers.get("server-timing") ?? "").split(", ");
      const dur = (n: string) => Number(parts.find((p) => p.startsWith(`${n};`))!.split("dur=")[1]);
      last = parts.join(", ");
      for (const name of ["app", ...names])
        expect(parts.find((p) => p.startsWith(`${name};`))).toMatch(/^[a-z]+;dur=\d+\.\d$/);
        expect(parts.find((p) => p.startsWith(`${name};`)), `phase ${name} in ${last}`).toMatch(/^[a-z]+;dur=\d+\.\d$/);
      total = Math.min(total, dur("app"));
      
        junipercrew
        17d ago
        outdated
      
      Unbounded: against can be tens of ms under load, so this passes almost anything. Move it into the budget helper with a cap, and test it.
    
      // Phases name the whole request: what is left over is small.
      left = Math.min(left, Math.abs(dur("app") - names.reduce((sum, n) => sum + dur(n), 0)));
@@ -82,7 +84,12 @@
for (const [path, names] of PAGES)
    expectBudget(total, { ms: BUDGET_MS, against });
    // The unnamed stretch (routing, before `session`) is fixed work, ~0.9 ms quiet and ~1.7 ms in a loaded
    // shard (#7519): it stretches with the machine, so it is judged against the same-run baseline like speed.
    expectBudget(left, { ms: ACCOUNTING_MS, against });
    try {
      expectBudget(left, { ms: ACCOUNTING_MS, against });
    } catch (e) {
      // Name the phases, so a red says whether the machine stalled or a phase went missing.
      throw new Error(`${(e as Error).message}; best app ${total.toFixed(1)} ms; last request ${last}`);
    }
  });
// Signed out, the redirect to sign-in is still a named phase.
		@@ -68,13 +68,15 @@ for (const [path, names] of PAGES)
68	68	// Timers jitter on a busy machine: judge the best of several requests.
69	69	let left = Infinity;
70	70	let total = Infinity;
	71	let last = "";
71	72	for (let i = 0; i < SAMPLES; i++) {
72	73	const res = await get();
73	74	await res.text();
74	75	const parts = (res.headers.get("server-timing") ?? "").split(", ");
75	76	const dur = (n: string) => Number(parts.find((p) => p.startsWith(`${n};`))!.split("dur=")[1]);
	77	last = parts.join(", ");
76	78	for (const name of ["app", ...names])
77		expect(parts.find((p) => p.startsWith(`${name};`))).toMatch(/^[a-z]+;dur=\d+\.\d$/);
	79	expect(parts.find((p) => p.startsWith(`${name};`)), `phase ${name} in ${last}`).toMatch(/^[a-z]+;dur=\d+\.\d$/);
78	80	total = Math.min(total, dur("app"));
		junipercrew 17d ago outdated Unbounded: `against` can be tens of ms under load, so this passes almost anything. Move it into the budget helper with a cap, and test it.
79	81	// Phases name the whole request: what is left over is small.
80	82	left = Math.min(left, Math.abs(dur("app") - names.reduce((sum, n) => sum + dur(n), 0)));
		@@ -82,7 +84,12 @@ for (const [path, names] of PAGES)
82	84	expectBudget(total, { ms: BUDGET_MS, against });
83	85	// The unnamed stretch (routing, before `session`) is fixed work, ~0.9 ms quiet and ~1.7 ms in a loaded
84	86	// shard (#7519): it stretches with the machine, so it is judged against the same-run baseline like speed.
85		expectBudget(left, { ms: ACCOUNTING_MS, against });
	87	try {
	88	expectBudget(left, { ms: ACCOUNTING_MS, against });
	89	} catch (e) {
	90	// Name the phases, so a red says whether the machine stalled or a phase went missing.
	91	throw new Error(`${(e as Error).message}; best app ${total.toFixed(1)} ms; last request ${last}`);
	92	}
86	93	});
87	94
88	95	// Signed out, the redirect to sign-in is still a named phase.