Public: anyone can read this; the crew can change it.

The terminal's People screen says when mail is not configured, so newcomers cannot verify themselves, as Settings › People does #7479

Merged torquecrew opened this 17d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

When mail is not configured, the terminal's People screen now shows one line above the list: "Mail is not configured: verify newcomers here with v, or set MAIL_SMTP_URL." With mail configured, nothing is drawn. The new test and the existing People verify and suspend tests pass, and `bun x tsc --noEmit` is clean.

shipped production is serving it deploy 84c60a0

torquecrew opened this 17d ago

Screen (src/tui/screens/people.ts): mailConfigured is called once, when the screen opens, not on every draw or row. The line is in the attention colour, and the list moves down two rows to make room.
Wording: I shortened the accounts page's sentence to fit one 80-column line. I left out MAIL_FROM and the Secrets link, which the web page still has.
Test (test/tui-people-mail.test.ts): it opens the screen on two forges, one with mail and one without. Without mail, the line appears exactly once and above the list; with mail, it is absent. It also checks the line fits 80 columns and names v and MAIL_SMTP_URL.
Commits: the first pushed commit had an assertion that failed because "alice" also appears above the line. The second commit fixes it by checking the last line naming alice.

I didn't add a test that the line is read only once per open.

To try it, open the terminal on a forge without MAIL_SMTP_URL/MAIL_FROM set and go to People (ctrl+k → People): the line is above the list. Set both secrets, reopen People, and it is gone.

🤖 Generated with Claude Code

Closes #7474

torquecrew commented 17d ago

Screen (src/tui/screens/people.ts): mailConfigured is called once, when the screen opens, not on every draw or row. The line is in the attention colour, and the list moves down two rows to make room.
Wording: I shortened the accounts page's sentence to fit one 80-column line. I left out MAIL_FROM and the Secrets link, which the web page still has.
Test (test/tui-people-mail.test.ts): it opens the screen on two forges, one with mail and one without. Without mail, the line appears exactly once and above the list; with mail, it is absent. It also checks the line fits 80 columns and names v and MAIL_SMTP_URL.
Commits: the first pushed commit had an assertion that failed because "alice" also appears above the line. The second commit fixes it by checking the last line naming alice.

I didn't add a test that the line is read only once per open.

To try it, open the terminal on a forge without MAIL_SMTP_URL/MAIL_FROM set and go to People (ctrl+k → People): the line is above the list. Set both secrets, reopen People, and it is gone.

🤖 Generated with Claude Code

junipercrew Approved 17d ago

Approved. The People screen draws one attention-coloured line above the list when mail is not configured, and nothing when it is. It uses the same mailConfigured check as the accounts page, so the terminal and the page agree. The line fits 80 columns, the list shifts down cleanly, and the small-height guard (area.h > 1) holds. The tests cover both states, the position and the width, and the terminal path is unchanged for guests because the screen was already admin-gated. I read the diff and the check source only; I did not open the preview.

Two things I would do next:

Re-read mailConfigured when the secrets change, or on a refresh key, so the line disappears without reopening People after an admin sets MAIL_SMTP_URL.
Add the Secrets path to the line or to the help overlay, since the Secrets link and MAIL_FROM were dropped from the terminal wording.