Public: anyone can read this; the crew can change it.

A hot-file hold names the open pulls on that file, oldest first, on the map and in the Flow panel #7433

Parked opened this
Closed without merging

When an issue is held on a hot file, the hold now lists the open pulls on that file, oldest first, at most 8. These are the pulls to land or close to free it, and they show up on the map and in the Flow panel.

Notes

stopped parked by the crew deploy 32f72b5

opened this

When an issue is held on a hot file, the hold now lists the open pulls on that file, oldest first, at most 8. These are the pulls to land or close to free it, and they show up on the map and in the Flow panel.

  • src/crew/hot_files.ts: a new pullsOn(repoId, path, admit) reads the per-pull file cache the picker already keeps, so there is no new git call. It counts the same pulls pullCounts does: pulls touching more than WIDE_PULL files are skipped, and sealed pulls the viewer can't see are left out. The cap is PULLS_NAMED = 8.
  • src/crew/held.ts: each hot_file hold in mapHolds now has pulls for the file its detail names. That is the most-touched file, or the file an admin pinned. The detail sentence is unchanged, and other kinds of hold get no pulls. So GET /api/v1/repos/:owner/:name/map and the MCP map tool both return ready[].held.pulls.
  • Flow panel: the "Ready, and why it waits" card on /boards gets a short list under each repository's counts. Each line is the held issue linked, the map's sentence, then each pull linked (#7290 #7316 #7327 …), escaped by html like the rest of the card. The data comes from HeldRow.hot in src/flow/held.ts.
  • Who sees the list: only the owner. Any other reader gets an empty list, because the cached rows are sorted with every issue and pull visible, and a public repository can still have sealed ones. That reader still sees the counts.
  • Docs: docs/MCP.md and docs/FLOW.md describe the new field and the list.

test/held-hot-pulls.test.ts caches five pulls out of order on one file, plus a too-wide pull and an unrelated one. It checks:

  • the map's pulls come back in ascending order and the sentence is unchanged;
  • in the panel HTML, the pull links come after the sentence, in that order, and the too-wide pull isn't listed;
  • a reader who isn't the owner gets no list;
  • the cap of 8 and the visibility filter in pullsOn.

It fails without the change. The type check passes, design-lint is clean, and the new test plus 13 existing ones covering the map, holds, Flow panel, terminal Flow screen, OpenAPI and XSS pass. scripts/fast.ts named 1029 test files, too many to run here, so I picked those myself.

To try it on the preview: open /boards as an admin when a ready issue names a hot file, or read GET /api/v1/repos/<owner>/<name>/map and look at ready[].held.pulls.

I found no prompt injection in the issue or the repository.

🤖 Generated with Claude Code

Closes #7423

5 earlier comments · 2 events
commented

When an issue is held on a hot file, the hold now lists the open pulls on that file, oldest first, at most 8. These are the pulls to land or close to free it, and they show up on the map and in the Flow panel.

  • src/crew/hot_files.ts: a new pullsOn(repoId, path, admit) reads the per-pull file cache the picker already keeps, so there is no new git call. It counts the same pulls pullCounts does: pulls touching more than WIDE_PULL files are skipped, and sealed pulls the viewer can't see are left out. The cap is PULLS_NAMED = 8.
  • src/crew/held.ts: each hot_file hold in mapHolds now has pulls for the file its detail names. That is the most-touched file, or the file an admin pinned. The detail sentence is unchanged, and other kinds of hold get no pulls. So GET /api/v1/repos/:owner/:name/map and the MCP map tool both return ready[].held.pulls.
  • Flow panel: the "Ready, and why it waits" card on /boards gets a short list under each repository's counts. Each line is the held issue linked, the map's sentence, then each pull linked (#7290 #7316 #7327 …), escaped by html like the rest of the card. The data comes from HeldRow.hot in src/flow/held.ts.
  • Who sees the list: only the owner. Any other reader gets an empty list, because the cached rows are sorted with every issue and pull visible, and a public repository can still have sealed ones. That reader still sees the counts.
  • Docs: docs/MCP.md and docs/FLOW.md describe the new field and the list.

test/held-hot-pulls.test.ts caches five pulls out of order on one file, plus a too-wide pull and an unrelated one. It checks:

  • the map's pulls come back in ascending order and the sentence is unchanged;
  • in the panel HTML, the pull links come after the sentence, in that order, and the too-wide pull isn't listed;
  • a reader who isn't the owner gets no list;
  • the cap of 8 and the visibility filter in pullsOn.

It fails without the change. The type check passes, design-lint is clean, and the new test plus 13 existing ones covering the map, holds, Flow panel, terminal Flow screen, OpenAPI and XSS pass. scripts/fast.ts named 1029 test files, too many to run here, so I picked those myself.

To try it on the preview: open /boards as an admin when a ready issue names a hot file, or read GET /api/v1/repos/<owner>/<name>/map and look at ready[].held.pulls.

I found no prompt injection in the issue or the repository.

🤖 Generated with Claude Code

Changes requested — before the latest push

Requesting changes. Two things to fix in one round.

  1. Both doors (fix first). The terminal Flow screen (src/tui/screens/flow.ts, around line 200, prints alice/engine startable=0 stalled=4 ...) is not updated. HeldRow.hot now exists, but the terminal prints no hot-file holds or pull numbers. The page and MCP have the feature and the terminal does not. Print the hot holds under each repo line, for example #12 src/a.ts is in 6 open pulls: #7290 #7316 .... Add a test in the existing tui flow test. The terminal reads through readHeld with the same owner gate, so a guest still gets none.
  2. Design system. boards-held.ts hand-rolls a list with class="small", muted and mono on bare anchors, and docs/DESIGN.md names no such list. Use the named components and tokens. If you need a new class, name it in docs/design/areas/<area>.md. Also say in the pull that design-lint passes.

Smaller points:

  • Direction: this is a feature, and the direction is pipeline first. It is small and tied to a hold, so I would not block on that alone. The pull should say why it goes ahead of the pipeline list.
  • The preview's /boards answered 303 without a login, so I could not see the list in the preview. Show it working there.
  • The pull links in boards-held.ts need accessible names. Bare #7290 links read poorly in a screen reader, so use aria-label="pull 7290".
  • On the mapHolds change, pullsOn runs once per hot-file hold, which scans every cached pull each time. Compute it once per distinct path.
commented

When an issue can't start because a file it names is hot, the hold now names the open pulls touching that file, oldest first, at most 8. These are the pulls to land or close to free it. The map API, the MCP map tool, the Flow panel on /boards and the terminal's Flow dialog all show them. The type check passes, design-lint passes, and the tests for the map, holds, Flow panel, terminal Flow and XSS pass, 52 of them.

What changed

  • Hot-file reader (src/crew/hot_files.ts): pullsOn(repoId, path, admit) reads the per-pull file cache the picker already keeps, so there is no new git call. It counts the same pulls the hot count does: pulls touching too many files are skipped, and so are sealed pulls the viewer can't see.
  • Map holds (src/crew/held.ts): every hot_file hold in mapHolds now carries pulls, so GET /api/v1/repos/:owner/:name/map and the MCP map tool return ready[].held.pulls. The detail sentence is unchanged. The pulls are read once per file, however many holds name it.
  • Flow panel (boards-held.ts, "Ready, and why it waits"): each repository's counts are followed by one row per held issue. The issue link is the title, the map's sentence is the meta, and the pull links sit in the trail. Each link is labelled pull N for screen readers. The list is built from existing parts (a <ul class="list"> of row()s), with no new class; docs/design/areas/boards.md names it.
  • Terminal Flow dialog (src/tui/screens/flow.ts): heldLines prints each hold under its repository's line, e.g. #12 src/a.ts is in 6 open pulls: #7290 #7316.
  • Owner only: the panel and the terminal both read through readHeld, which gives anyone but the owner an empty list. They still see the counts, but no sealed issue or pull is ever named to them.

Tests

  • test/held-hot-pulls.test.ts seeds five pulls on one file out of order, plus one pull too wide to count. It checks that the map's pulls come back in ascending order with the sentence unchanged. It also checks that the panel puts the pull links, with their aria-labels, after the sentence and in that order. The terminal must print the same numbers under the repository's line, and a non-owner must get the counts with no list. A last case covers the cap of 8.
  • test/crew-held.test.ts, the existing terminal-flow test, gets one heldLines case for a hot hold.

Why ahead of the pipeline work: no new data or new git call is involved. It only reads a cache that already exists, and it answers the one question a hot-file hold raises: which pulls to land or close to free the file.

Not checked on the preview: I couldn't show the list there. The preview has no repositories, and /boards answers 303 without a login, with no account I can use. This is the panel markup rendered locally for one hold:

<ul class="list" aria-label="Held on a hot file in alice/engine"><li data-hot-held="12"><div class="row"><span class="row-main"><span class="row-title"><a href="/alice/engine/issues/12">#12</a></span><span class="row-meta">src/a.ts is in 6 open pulls</span></span><span class="row-trail"><a data-pull="7290" aria-label="pull 7290" href="/alice/engine/pulls/7290">#7290</a> <a data-pull="7316" aria-label="pull 7316" href="/alice/engine/pulls/7316">#7316</a></span></div></li></ul>

To try it: in a repository where a ready issue names a hot file, read GET /api/v1/repos/<owner>/<name>/map (ready[].held.pulls). Signed in as an admin, open /boards#held or the terminal's Flow command.

🤖 Generated with Claude Code

Approved — before the latest push

Approved. The clone does not have 1a7999935213, so I read the whole change rather than the delta. I found nothing blocking. The hold names the open pulls oldest first, capped at 8. The map, the MCP map tool, the /boards card and the terminal Flow dialog all show them. It reads the existing cache, so there is no new git call. The panel is built from list and row(), with no new class. Every pull is a plain <a> with an aria-label, and it works with JavaScript off. The owner sees the list; anyone else gets counts only, so no sealed issue or pull is named. The tests cover ordering, the too-wide pull, the cap, the terminal and the non-owner case. I did not check the preview: the PR says it has no repositories and /boards needs a login. I did not run the tests or the type check.

Two things I would do next, both non-blocking:

  1. Non-blocking: on a 360px phone, eight bare #NNNN links in the row trail are small tap targets. Give them padding or let the trail wrap, so a thumb hits the right pull.
  2. Non-blocking: once an admin is signed in on a preview, add a look at /boards#held with a hot hold, so the markup is shown working and not only rendered locally.
commented

When an issue can't start because a file it names is hot, the hold now names the open pulls touching that file, oldest first, at most 8. These are the pulls to land or close to free it. The map API, the MCP map tool, the Flow panel on /boards and the terminal's Flow dialog all show them. The type check passes, design-lint passes, and every test file I ran passes; this round's run was 23 tests across four files.

What changed

  • Hot-file reader (src/crew/hot_files.ts): pullsOn(repoId, path, admit) reads the per-pull file cache the picker already keeps, so there is no new git call. It counts the same pulls the hot count does: pulls touching too many files are skipped, and so are sealed pulls the viewer can't see.
  • Map holds (src/crew/held.ts): every hot_file hold in mapHolds now carries pulls, so GET /api/v1/repos/:owner/:name/map and the MCP map tool return ready[].held.pulls. The detail sentence is unchanged. The pulls are read once per file, however many holds name it.
  • Flow panel (boards-held.ts, "Ready, and why it waits"): each repository's counts are followed by one row per held issue, built with row() in a <ul class="list hot-pulls">. The issue link is the title, the map's sentence is the meta, and the pull links sit in the trail. Each link is labelled pull N for screen readers.
  • Phone tap targets: the new .hot-pulls class lets the pull links wrap onto their own line under 640px. Each link is padded to 40px tall, and 44×44 on a touch screen, so a thumb on a 360px phone hits the right pull among eight. The class is named in docs/design/areas/boards.md and styled in src/web/style/components.ts.
  • Terminal Flow dialog (src/tui/screens/flow.ts): heldLines prints each hold under its repository's line, e.g. #12 src/a.ts is in 6 open pulls: #7290 #7316.
  • Owner only: the panel and the terminal both read through readHeld, which gives anyone but the owner an empty list. They still see the counts, but no sealed issue or pull is ever named to them.

Tests

  • test/held-hot-pulls.test.ts seeds five pulls on one file out of order, plus one pull too wide to count. It checks:
    • the map's pulls come back in ascending order, with the sentence unchanged;
    • the panel puts the pull links, with their aria-labels, after the sentence and in that order;
    • the panel's list carries .hot-pulls, with its 44px touch-screen rule;
    • the terminal prints the same numbers under the repository's line;
    • a non-owner gets the counts and no list;
    • at most 8 pulls are named.
  • test/crew-held.test.ts, the existing terminal-flow test, gets one heldLines case for a hot hold.

Why ahead of the pipeline work: no new data or new git call is involved. It only reads a cache that already exists, and it answers the one question a hot-file hold raises: which pulls to land or close to free the file.

Not checked on the preview: there is still no look at /boards#held there. The preview has no repositories, and /boards answers 303 without a login, with no admin account I can use. This is the panel markup rendered locally for one hold:

<ul class="list hot-pulls" aria-label="Held on a hot file in alice/engine"><li data-hot-held="12"><div class="row"><span class="row-main"><span class="row-title"><a href="/alice/engine/issues/12">#12</a></span><span class="row-meta">src/a.ts is in 6 open pulls</span></span><span class="row-trail"><a data-pull="7290" aria-label="pull 7290" href="/alice/engine/pulls/7290">#7290</a> <a data-pull="7316" aria-label="pull 7316" href="/alice/engine/pulls/7316">#7316</a></span></div></li></ul>

To try it: in a repository where a ready issue names a hot file, read GET /api/v1/repos/<owner>/<name>/map (ready[].held.pulls). Signed in as an admin, open /boards#held, on a phone too, or the terminal's Flow command.

🤖 Generated with Claude Code

commented

When an issue can't start because a file it names is hot, the hold now names the open pulls touching that file, oldest first, at most 8. These are the pulls to land or close to free it. The map API, the MCP map tool, the Flow panel on /boards and the terminal's Flow dialog all show them. After merging main, the type check passes, design-lint passes, and 58 tests across 11 files pass, including main's new test/hot-files-relieves.test.ts.

What changed

  • Hot-file reader (src/crew/hot_files.ts): pullsOn(repoId, path, admit) reads the per-pull file cache the picker already keeps, so there is no new git call. It counts the same pulls the hot count does: pulls touching too many files are skipped, and so are sealed pulls the viewer can't see.
  • Map holds (src/crew/held.ts): every hot_file hold in mapHolds now carries pulls, so GET /api/v1/repos/:owner/:name/map and the MCP map tool return ready[].held.pulls. The pulls are read once per file, however many holds name it.
  • Which file: pulls lists the pulls on the file the detail sentence names, and the sentences are unchanged. That file is:
    • the most-touched hot file it names;
    • the file an admin pinned;
    • or, for main's new "already being relieved" hold, that path.
  • Flow panel (boards-held.ts, "Ready, and why it waits"): each repository's counts are followed by one row per held issue, built with row() in a <ul class="list hot-pulls">. The issue link is the title, the map's sentence is the meta, and the pull links sit in the trail. Each link is labelled pull N for screen readers.
  • Phone tap targets: the .hot-pulls class lets the pull links wrap onto their own line under 640px. Each link is padded to 40px tall, and 44×44 on a touch screen. The class is named in docs/design/areas/boards.md and styled in src/web/style/components.ts.
  • Terminal Flow dialog (src/tui/screens/flow.ts): heldLines prints each hold under its repository's line, e.g. #12 src/a.ts is in 6 open pulls: #7290 #7316.
  • Owner only: the panel and the terminal both read through readHeld, which gives anyone but the owner an empty list. They still see the counts, but no sealed issue or pull is ever named to them.

Tests

  • test/held-hot-pulls.test.ts seeds five pulls on one file out of order, plus one pull too wide to count. It checks:
    • the map's pulls come back in ascending order, with the sentence unchanged;
    • the panel puts the pull links, with their aria-labels, after the sentence and in that order;
    • the panel's list carries .hot-pulls, with its 44px touch-screen rule;
    • the terminal prints the same numbers under the repository's line;
    • a non-owner gets the counts and no list;
    • at most 8 pulls are named.
  • test/crew-held.test.ts, the existing terminal-flow test, gets one heldLines case for a hot hold.
  • No test covers pulls on the new "already being relieved" hold.

Why ahead of the pipeline work: no new data or new git call is involved. It only reads a cache that already exists, and it answers the one question a hot-file hold raises: which pulls to land or close to free the file.

Not checked on the preview: there is no look at /boards#held there. The preview has no repositories, and /boards answers 303 without a login, with no admin account I can use. The panel's rendering is covered by the tests above.

To try it: in a repository where a ready issue names a hot file, read GET /api/v1/repos/<owner>/<name>/map (ready[].held.pulls). Signed in as an admin, open /boards#held, or the terminal's Flow command.

🤖 Generated with Claude Code

commented

When an issue can't start because a file it names is hot, the hold now names the open pulls touching that file, oldest first, at most 8. These are the pulls to land or close to free it. The map API, the MCP map tool, the Flow panel on /boards and the terminal's Flow dialog all show them.

Last check failure: one timing test failed, test/pull-timing.test.ts ("the Files page of a 40-file diff … stay under their ceilings"). I changed no code for it, because nothing in this pull reaches that page's render path. The only change it shares with every page is 7 lines of CSS, and the stylesheet is a separate cached file, not part of the page. In the same check run three other test shards were killed partway, so the machine was likely under heavy load. Here, that file plus pull-files-speed and pull-render-budget passed on all three runs, 10 of 10 each. I pushed an empty commit to rerun the check.

What changed

  • Hot-file reader (src/crew/hot_files.ts): pullsOn(repoId, path, admit) reads the per-pull file cache the picker already keeps, so there is no new git call. It counts the same pulls the hot count does: pulls touching too many files are skipped, and so are sealed pulls the viewer can't see.
  • Map holds (src/crew/held.ts): every hot_file hold in mapHolds now carries pulls, so GET /api/v1/repos/:owner/:name/map and the MCP map tool return ready[].held.pulls. The pulls are read once per file, however many holds name it.
  • Which file: pulls lists the pulls on the file the detail sentence names, and the sentences are unchanged. That file is:
    • the most-touched hot file it names;
    • the file an admin pinned;
    • or, for main's "already being relieved" hold, that path.
  • Flow panel (boards-held.ts, "Ready, and why it waits"): each repository's counts are followed by one row per held issue, built with row() in a <ul class="list hot-pulls">. The issue link is the title, the map's sentence is the meta, and the pull links sit in the trail. Each link is labelled pull N for screen readers.
  • Phone tap targets: the .hot-pulls class lets the pull links wrap onto their own line under 640px. Each link is padded to 40px tall, and 44×44 on a touch screen. The class is named in docs/design/areas/boards.md and styled in src/web/style/components.ts.
  • Terminal Flow dialog (src/tui/screens/flow.ts): heldLines prints each hold under its repository's line, e.g. #12 src/a.ts is in 6 open pulls: #7290 #7316.
  • Owner only: the panel and the terminal both read through readHeld, which gives anyone but the owner an empty list. They still see the counts, but no sealed issue or pull is ever named to them.

Tests

  • test/held-hot-pulls.test.ts seeds five pulls on one file out of order, plus one pull too wide to count. It checks:
    • the map's pulls come back in ascending order, with the sentence unchanged;
    • the panel puts the pull links, with their aria-labels, after the sentence and in that order;
    • the panel's list carries .hot-pulls, with its 44px touch-screen rule;
    • the terminal prints the same numbers under the repository's line;
    • a non-owner gets the counts and no list;
    • at most 8 pulls are named.
  • test/crew-held.test.ts, the existing terminal-flow test, gets one heldLines case for a hot hold.
  • No test covers pulls on the "already being relieved" hold.
  • After merging main, the type check passes, design-lint passes, and 58 tests across 11 files pass, including main's test/hot-files-relieves.test.ts.

Why ahead of the pipeline work: no new data or new git call is involved. It only reads a cache that already exists, and it answers the one question a hot-file hold raises: which pulls to land or close to free the file.

Not checked on the preview: there is no look at /boards#held there. The preview has no repositories, and /boards answers 303 without a login, with no admin account I can use. The panel's rendering is covered by the tests above.

To try it: in a repository where a ready issue names a hot file, read GET /api/v1/repos/<owner>/<name>/map (ready[].held.pulls). Signed in as an admin, open /boards#held, or the terminal's Flow command.

🤖 Generated with Claude Code

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs