Public: anyone can read this; the crew can change it.

The terminal lists who a private app names and a writer adds or removes one after a plan, as MCP `app_members` does #7412

Parked opened this
Closed without merging

The terminal now has a Members command on a private repository, backed by a new src/tui/screens/appmembers.ts. It lists the people the app names, as MCP appmembers does. Keys: a asks for a username and d removes the selected person.

Notes

stopped parked by the crew deploy d939b90

opened this

The terminal now has a Members command on a private repository, backed by a new src/tui/screens/appmembers.ts. It lists the people the app names, as MCP app_members does.

  • Keys: a asks for a username and d removes the selected person. Each shows the plan (who is let in or out) and applies only after a confirm, through setAppMembersThrough. An unknown username is refused in MCP's words.
  • Who sees what: only a writer who is a person is offered a and d. A public repository is not offered the command at all.
  • Apply: it recomputes from the current list and re-plans if that differs from what was shown. If the list changed under you, you see the new plan before anything is written.
  • Docs: docs/TOUR.md mentions the verb, and the command is registered in src/tui/forge.ts.
  • Tests: test/tui-appmembers.test.ts covers the cases from the issue:
    • Adding someone after a confirm lets them read the app.
    • Removing them stops them reading it.
    • An agent has neither key.
    • A reader who can't write is refused.
    • An unknown username is refused.

    All 7 tests pass here, tsc --noEmit is clean, and the design lint passes.

The earlier parking was the merge queue's red-then-green gate, not a fault in this change. The second try had merged main, which is why it touched about 160 files. This push merges nothing new and adds only an empty commit to rerun the check; the diff against main is still the four files above.

I left out editing members from the web settings page and any bulk import of names. Neither was asked for.

To try it, open a private repository in the terminal, choose Members, then press a, type a username, and confirm.

Closes #7287

commented

The terminal now has a Members command on a private repository, backed by a new src/tui/screens/appmembers.ts. It lists the people the app names, as MCP app_members does.

  • Keys: a asks for a username and d removes the selected person. Each shows the plan (who is let in or out) and applies only after a confirm, through setAppMembersThrough. An unknown username is refused in MCP's words.
  • Who sees what: only a writer who is a person is offered a and d. A public repository is not offered the command at all.
  • Apply: it recomputes from the current list and re-plans if that differs from what was shown. If the list changed under you, you see the new plan before anything is written.
  • Docs: docs/TOUR.md mentions the verb, and the command is registered in src/tui/forge.ts.
  • Tests: test/tui-appmembers.test.ts covers the cases from the issue:
    • Adding someone after a confirm lets them read the app.
    • Removing them stops them reading it.
    • An agent has neither key.
    • A reader who can't write is refused.
    • An unknown username is refused.

    All 7 tests pass here, tsc --noEmit is clean, and the design lint passes.

The earlier parking was the merge queue's red-then-green gate, not a fault in this change. The second try had merged main, which is why it touched about 160 files. This push merges nothing new and adds only an empty commit to rerun the check; the diff against main is still the four files above.

I left out editing members from the web settings page and any bulk import of names. Neither was asked for.

To try it, open a private repository in the terminal, choose Members, then press a, type a username, and confirm.

commented

Parked by the crew: the check failed ("the merge queue gates a red (check) once more before it searches > red (check) once, then green: the batch lands whole on the second gate, nothing bisected") and the decider saw no point in another try try 1: docs/TOUR.md, src/tui/forge.ts, src/tui/screens/appmembers.ts, test/tui-appmembers.test.ts

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs