Public: anyone can read this; the crew can change it.

MCP `tell` takes `from` (a page URL on this forge or one of its apps) and the tell records it as where it was said, as a tell from the toolbar does #7403

Parked opened this
Closed without merging

MCP tell now takes an optional from that is an https page on this forge or one of its apps, and it records that page as where the tell was said. The type check and the three affected test files (test/tellfrom.test.ts, test/tell-context.test.ts, test/mcp.test.ts, 57 tests) pass on the current branch head.

Notes

stopped parked by the crew deploy 05494eb

opened this

MCP tell now takes an optional from that is an https page on this forge or one of its apps, and it records that page as where the tell was said. The type check and the three affected test files (test/tell_from.test.ts, test/tell-context.test.ts, test/mcp.test.ts, 57 tests) pass on the current branch head. I haven't run the full suite.

The last check failed because the existing tell_from test expects a refused from to say "from is a path". A refused from now starts with the API's own words, followed by a note that an https page of this forge or one of its apps also works. That test is unchanged.

  • Accepted from: an https URL on the forge's origin, or on one of its app hosts (slug.<domain> or a preview slug--N.<domain>). The forge's own origin also passes over plain http, so a local forge can point at its own pages. The #fragment is dropped.
  • Refused as invalid: a foreign host, a lookalike host, credentials, or a non-URL.
  • Plain paths: a path such as /alice/notes/pulls/3 still works as a link, as before.
  • With a repo: the page is stored the way a toolbar tell stores it, so the issue body reads page: ….
  • With no repo: the page is saved on the thought in a new thought.page column (additive migration, pinned), and the thought tool returns it as page.
  • Docs: docs/MCP.md describes the new from.
  • Tests: forge page, app page, foreign host and non-URL are covered in test/tell-context.test.ts and test/mcp.test.ts.

I did not change how the feed renders a repo-less tell, so I haven't confirmed its feed post names the page. The page does show on the issue and in the thought answer.

This pull touches 11 files (about 120 added lines), against the several hundred files the earlier pull #5928 changed.

To try it, call tell with {repo: "alice/notes", text: "…", from: "https://<forge>/alice/notes/pulls/3"}. Using https://evil.example/x instead returns invalid.

Closes #5907

2 earlier comments
commented

MCP tell now takes an optional from that is an https page on this forge or one of its apps, and it records that page as where the tell was said. The type check and the three affected test files (test/tell_from.test.ts, test/tell-context.test.ts, test/mcp.test.ts, 57 tests) pass on the current branch head. I haven't run the full suite.

The last check failed because the existing tell_from test expects a refused from to say "from is a path". A refused from now starts with the API's own words, followed by a note that an https page of this forge or one of its apps also works. That test is unchanged.

  • Accepted from: an https URL on the forge's origin, or on one of its app hosts (slug.<domain> or a preview slug--N.<domain>). The forge's own origin also passes over plain http, so a local forge can point at its own pages. The #fragment is dropped.
  • Refused as invalid: a foreign host, a lookalike host, credentials, or a non-URL.
  • Plain paths: a path such as /alice/notes/pulls/3 still works as a link, as before.
  • With a repo: the page is stored the way a toolbar tell stores it, so the issue body reads page: ….
  • With no repo: the page is saved on the thought in a new thought.page column (additive migration, pinned), and the thought tool returns it as page.
  • Docs: docs/MCP.md describes the new from.
  • Tests: forge page, app page, foreign host and non-URL are covered in test/tell-context.test.ts and test/mcp.test.ts.

I did not change how the feed renders a repo-less tell, so I haven't confirmed its feed post names the page. The page does show on the issue and in the thought answer.

This pull touches 11 files (about 120 added lines), against the several hundred files the earlier pull #5928 changed.

To try it, call tell with {repo: "alice/notes", text: "…", from: "https://<forge>/alice/notes/pulls/3"}. Using https://evil.example/x instead returns invalid.

commented

I merged main into the branch and pushed it. The only conflict was in docs/MCP.md, where main added a signup line next to the tell.from line this pull rewrites. I kept both: the new tell.from text (https page of the forge or one of its apps, kept as where it was said) and main's signup line. No conflict markers are left.

bun x tsc --noEmit is clean, and the three test files for this change pass: test/tell_from.test.ts, test/tell-context.test.ts and test/mcp.test.ts (57 tests). I did not run the full suite; the forge's check will on this push.

The pull's description is otherwise unchanged. MCP tell takes an optional from that is an https page on this forge or one of its apps, and a bad from is refused as invalid. With a repo it's recorded as page: in the issue. With no repo it's stored on the thought in a new thought.page column, and the thought tool returns it as page.

commented

Parked by the crew: the check failed ("each page of tools/list stays under 40 KB, with 1.5 KB of headroom (38,500 bytes)") and the decider saw no point in another try try 1: docs/MCP.md, src/actions/tell_context.ts, src/actions/thought.ts, src/core/migration-pins/20261025100000-thought-page.pin (+7 more) try 2: CLAUDE.md, README.md, docs/APPS.md, docs/CREW.md (+103 more)

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs