Public: anyone can read this; the crew can change it.

The terminal's deploys screen lists an app's custom domains, adds, checks and removes one, as MCP `app_domains` does #7383

Parked opened this
Closed without merging

The deploys screen now lists an app's custom domains and lets the app's admin add, check and remove them. tsc, design-lint and test/tui-deploys.test.ts, test/app-domains.test.ts and test/mcp-size.test.ts pass. I did not run the rest of the suite, because scripts/fast.ts called the diff too broad to name.

Notes

stopped parked by the crew deploy 487bc31

opened this

The deploys screen now lists an app's custom domains and lets the app's admin add, check and remove them. tsc, design-lint and test/tui-deploys.test.ts, test/app-domains.test.ts and test/mcp-size.test.ts pass. I did not run the rest of the suite, because scripts/fast.ts called the diff too broad to name.

What changed

  • List: src/tui/screens/deploys.ts shows each domain from listAppDomains under the header. A line reads > host · verified or host · <the action's sentence>, and "Not checked yet." until the first check.
  • Keys:
    • + opens a prompt and calls addAppDomain. A refusal keeps the prompt open in the page's words, and a success names the DNS records to publish.
    • tab moves the domain cursor.
    • k calls checkAppDomain and, if the domain isn't verified, names the record still to publish.
    • - asks remove <host>? y/n and calls removeAppDomain.
  • Non-admins: listAppDomains fails for anyone who isn't the app's admin, so they see no domains and no keys. + does nothing for them.
  • Shared words: the refusal sentences and the records-in-words helper moved out of the settings page into src/actions/domain_words.ts, so the page and the terminal say the same thing. src/web/pages/settings.ts now imports them; its behaviour is unchanged.
  • Tests: a new case in test/tui-deploys.test.ts covers a bad name, a taken name, add, list, check with a stub DNS resolver, remove with n then y, and a non-admin who gets no keys. That non-admin's addAppDomain is refused with not_found.

Behaviours you might trip over

  • k conflicts with "move up". Once a domain is listed, k checks the selected domain for an admin; the up arrow still moves up in the deploy list.
  • y and n answer the remove confirm directly, through a thin wrapper in the screen. The shared confirmScreen is untouched.

Left out: no new MCP tool and no changes to app_domains. The terminal shows one note of up to three wrapped lines for the last action, not a history.

To try it, open an app's Deploys screen as its admin and press +.

🤖 Generated with Claude Code

Closes #7322

commented

The deploys screen now lists an app's custom domains and lets the app's admin add, check and remove them. tsc, design-lint and test/tui-deploys.test.ts, test/app-domains.test.ts and test/mcp-size.test.ts pass. I did not run the rest of the suite, because scripts/fast.ts called the diff too broad to name.

What changed

  • List: src/tui/screens/deploys.ts shows each domain from listAppDomains under the header. A line reads > host · verified or host · <the action's sentence>, and "Not checked yet." until the first check.
  • Keys:
    • + opens a prompt and calls addAppDomain. A refusal keeps the prompt open in the page's words, and a success names the DNS records to publish.
    • tab moves the domain cursor.
    • k calls checkAppDomain and, if the domain isn't verified, names the record still to publish.
    • - asks remove <host>? y/n and calls removeAppDomain.
  • Non-admins: listAppDomains fails for anyone who isn't the app's admin, so they see no domains and no keys. + does nothing for them.
  • Shared words: the refusal sentences and the records-in-words helper moved out of the settings page into src/actions/domain_words.ts, so the page and the terminal say the same thing. src/web/pages/settings.ts now imports them; its behaviour is unchanged.
  • Tests: a new case in test/tui-deploys.test.ts covers a bad name, a taken name, add, list, check with a stub DNS resolver, remove with n then y, and a non-admin who gets no keys. That non-admin's addAppDomain is refused with not_found.

Behaviours you might trip over

  • k conflicts with "move up". Once a domain is listed, k checks the selected domain for an admin; the up arrow still moves up in the deploy list.
  • y and n answer the remove confirm directly, through a thin wrapper in the screen. The shared confirmScreen is untouched.

Left out: no new MCP tool and no changes to app_domains. The terminal shows one note of up to three wrapped lines for the last action, not a history.

To try it, open an app's Deploys screen as its admin and press +.

🤖 Generated with Claude Code

commented

Parked by the crew: the preview's deploy failed and the decider saw no point in another try try 1: src/actions/domain_words.ts, src/tui/screens/deploys.ts, src/web/pages/settings.ts, test/tui-deploys.test.ts try 2: CLAUDE.md, README.md, docs/APPS.md, docs/CREW.md (+103 more)

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs