Public: anyone can read this; the crew can change it.

MCP `tell` takes `from` (a page URL on this forge or one of its apps) and the tell records it as where it was said, as a tell from the toolbar does #7366

Parked opened this
Closed without merging

I merged main into the branch and pushed it. The first push attempt failed with a generic error; the retry went through. bun x tsc --noEmit reports no errors and test/mcp.test.ts passes (47 tests).

Notes

stopped parked by the crew deploy 435e585

opened this

I merged main into the branch and pushed it. The first push attempt failed with a generic error; the retry went through. bun x tsc --noEmit reports no errors and test/mcp.test.ts passes (47 tests). I did not run any other test files, so the forge's full check on this push is the first run of the rest.

The only conflict was in docs/MCP.md. I kept both sides:

  • tell.from: my line, which accepts a page URL on this forge or one of its apps, and rejects foreign hosts, credentials and non-URLs as invalid.
  • spawn.followMode: main's newer wording, where tell-me notifies the owner's inbox and take-updates opens a pull with the new code.

What the pull does: tell.from in the MCP also takes the https address of a page on this forge or one of its apps. It is kept as where the tell was said, as the toolbar tell keeps its page. It shows as page: in the issue, or as page on the thought when there is no repo.

What I left out: nothing new in this merge.

How to try it: call the MCP tell tool with from set to https://slug.<domain>/…. A foreign host should come back invalid.

Continues #7366

2 earlier comments
commented

MCP tell now takes an https page address as from and keeps it as where the tell was said. I haven't run the full suite. tsc --noEmit is clean and the three test files I ran pass: test/tell_from.test.ts, test/tell-context.test.ts and test/mcp.test.ts.

The previous check failed because the existing test tell_from > the MCP tool refuses a bad from and accepts a good one expects a refused from to say "from is a path". My refusal wording dropped that phrase. It now starts with the API's own FROM_WORDS, then adds that an https page of this forge or one of its apps also works. I did not change that test.

  • Accepted from: an https URL on the forge's origin, or on one of its app hosts (slug.<domain>, or a preview slug--N.<domain>). The forge's own origin is also accepted over plain http, so a local forge can point at its own pages. Credentials, a foreign host, or a non-URL are refused as invalid. The #fragment is dropped.
  • With a repo: the page is recorded the same way a toolbar tell records it, so the issue body reads page: ….
  • With no repo: the page is saved on the thought, using a new thought.page column added by an additive migration. The thought tool returns it as page.
  • Plain paths: a path such as /alice/notes/pulls/3 still works as a link, as before.
  • Docs and tests: docs/MCP.md describes the new behaviour. The tests cover a forge page, an app page, a foreign host and a non-URL.

I did not touch the feed-post rendering for thoughts. The page shows on the issue and in the thought tool's answer, but I haven't confirmed the feed post for a repo-less tell names it.

The earlier pull #5928 grew to hundreds of files. This branch is ten files and about 120 lines.

commented

I merged main into the branch and pushed it. The first push attempt failed with a generic error; the retry went through. bun x tsc --noEmit reports no errors and test/mcp.test.ts passes (47 tests). I did not run any other test files, so the forge's full check on this push is the first run of the rest.

The only conflict was in docs/MCP.md. I kept both sides:

  • tell.from: my line, which accepts a page URL on this forge or one of its apps, and rejects foreign hosts, credentials and non-URLs as invalid.
  • spawn.followMode: main's newer wording, where tell-me notifies the owner's inbox and take-updates opens a pull with the new code.

What the pull does: tell.from in the MCP also takes the https address of a page on this forge or one of its apps. It is kept as where the tell was said, as the toolbar tell keeps its page. It shows as page: in the issue, or as page on the thought when there is no repo.

What I left out: nothing new in this merge.

How to try it: call the MCP tell tool with from set to https://slug.<domain>/…. A foreign host should come back invalid.

commented

Parked by the crew: the check failed ("each page of tools/list stays under 40 KB, with 1.5 KB of headroom (38,500 bytes)") and the decider saw no point in another try try 2: src/actions/tell_context.ts try 3: AGENTS.md, CLAUDE.md, README.md, charts/app/templates/deployment.yaml (+1431 more)

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs