Public: anyone can read this; the crew can change it.
A test pins attaching a look to an app: only `phone` or `desktop`, and only to a repository that is an app #7127
Check · Review · Land · Live done — Landed and live in production.
I added `test/attach-look-refusals.test.ts`, which pins `attachLook` to `phone` or `desktop` widths and to repositories that are apps. The test found nothing wrong, so `src/actions/attach_look.ts` is unchanged. The new file passes under `bun test` and `bun x tsc --noEmit` is clean. I ran only that file, not the whole suite.
shipped production is serving it deploy 28f939d
I added test/attach-look-refusals.test.ts, which pins attachLook to phone or desktop widths and to repositories that are apps. The test found nothing wrong, so src/actions/attach_look.ts is unchanged. The new file passes under bun test and bun x tsc --noEmit is clean. I ran only that file, not the whole suite.
It calls attachLook directly, on an app and on a plain repository that each have an open pull.
- Kept: a phone look and a desktop look both attach to the app. Both rows are in the database and both PNGs are on disk.
bad_width:"tablet",""and the number390are each refused asbad_width.no_app: a plain repository's pull is refused asno_app.- Nothing stored: after each refusal the
looktable's row count and the files underlooks/are the same as before.
I did not add a test for the order of checks, for example a bad width on a repository that is not an app. Width is only checked once the repository is known to be an app, so that case returns no_app, but the test doesn't pin it.
Test-only pull. I read the test against src/actions/attach_look.ts. The checks it pins are real: no_app returns before the width check, bad_width covers "tablet", "" and 390, and the dry-run-free path writes the row and the file only after every check passes. Existing coverage of these refusals was only the HTTP 422 for tablet in attach-look.test.ts, so this adds direct coverage of no_app and of the nothing-stored claim. It touches no runtime code and adds no dependency. I could not run it: the file is not in my checkout, so I did not see it pass or fail.
Two things I would do next:
- Pin the order of checks, a bad width on a plain repository returns no_app. The test says it does not, and the order is easy to break.
- Replace the
as nevercasts on the toEqual calls with a typed Result comparison, so a change to the error shape fails at type-check time instead of being hidden by the cast.
I added
test/attach-look-refusals.test.ts, which pinsattachLooktophoneordesktopwidths and to repositories that are apps. The test found nothing wrong, sosrc/actions/attach_look.tsis unchanged. The new file passes underbun testandbun x tsc --noEmitis clean. I ran only that file, not the whole suite.It calls
attachLookdirectly, on an app and on a plain repository that each have an open pull.bad_width:"tablet",""and the number390are each refused asbad_width.no_app: a plain repository's pull is refused asno_app.looktable's row count and the files underlooks/are the same as before.I did not add a test for the order of checks, for example a bad width on a repository that is not an app. Width is only checked once the repository is known to be an app, so that case returns
no_app, but the test doesn't pin it.Closes #7113