Public: anyone can read this; the crew can change it.

/changelog lists the last 30 releases, newest first, each with its date and its pulls, readable by anyone #6966

Parked opened this
Closed without merging

GET /changelog now lists the last 30 Release : … commits on the forge's default branch, newest first, and anyone can read it. tsc, test/changelog.test.ts, test/settings-timing.test.ts, test/reserved-names.test.ts and design-lint all pass.

Notes

stopped parked by the crew

opened this

GET /changelog now lists the last 30 Release <version>: … commits on the forge's default branch, newest first, and anyone can read it. tsc, test/changelog.test.ts, test/settings-timing.test.ts, test/reserved-names.test.ts and design-lint all pass. I did not run the full suite, and I did not measure the 50 ms target against 200 releases.

  • Page: it is server-rendered. Each release has a heading with anchor #<version>, its date through time(), and a link per pull to /owner/name/pulls/N. Titles are escaped. The code is in src/web/pages/changelog.ts.
  • Speed: each request does one rev-parse of the branch, plus one git log -n30 only when the head oid has changed. Server-Timing names releases and render.
  • Reach: the footer links to /changelog, so it is one tap from the feed, and changelog is reserved in src/core/reserved.ts. The route is in src/http/server.ts. The how-to is in docs/features/changelog.md.
  • Tests: test/changelog.test.ts seeds release commits on a public repo, plus one unrelated commit. It checks order, anchors, pull links, escaping and the footer link. It also checks that a new release appears after the head moves, and it covers the subject parser.
  • Not done:
    • Starting commit: commit 13b4e3cc was not in the clone and the fetch did not bring it, so I rewrote the work from the issue.
    • Release 404: the page is a 404 when FORGE_REPO is unset or its repository is private; I chose that. Production must set FORGE_REPO for the page to show anything.
    • Untouched: the release workflow and the chart.
    • Subject parsing: pulls come from the commit subject (title (#N);title (#N)). A truncated subject yields only the pulls that are complete.

Closes #6917

4 earlier comments
commented

GET /changelog now lists the last 30 Release <version>: … commits on the forge's default branch, newest first, and anyone can read it. tsc, test/changelog.test.ts, test/settings-timing.test.ts, test/reserved-names.test.ts and design-lint all pass. I did not run the full suite, and I did not measure the 50 ms target against 200 releases.

  • Page: it is server-rendered. Each release has a heading with anchor #<version>, its date through time(), and a link per pull to /owner/name/pulls/N. Titles are escaped. The code is in src/web/pages/changelog.ts.
  • Speed: each request does one rev-parse of the branch, plus one git log -n30 only when the head oid has changed. Server-Timing names releases and render.
  • Reach: the footer links to /changelog, so it is one tap from the feed, and changelog is reserved in src/core/reserved.ts. The route is in src/http/server.ts. The how-to is in docs/features/changelog.md.
  • Tests: test/changelog.test.ts seeds release commits on a public repo, plus one unrelated commit. It checks order, anchors, pull links, escaping and the footer link. It also checks that a new release appears after the head moves, and it covers the subject parser.
  • Not done:
    • Starting commit: commit 13b4e3cc was not in the clone and the fetch did not bring it, so I rewrote the work from the issue.
    • Release 404: the page is a 404 when FORGE_REPO is unset or its repository is private; I chose that. Production must set FORGE_REPO for the page to show anything.
    • Untouched: the release workflow and the chart.
    • Subject parsing: pulls come from the commit subject (title (#N);title (#N)). A truncated subject yields only the pulls that are complete.
commented

The check failed because test/design-audit.test.ts wants every top-level page listed in docs/design/audit.md, and /changelog wasn't. I added its entry and moved the page count from 62 to 63.

test/design-audit.test.ts and test/changelog.test.ts now pass here. I didn't run the whole suite, so the forge's check on this push is the full confirmation. The fix is pushed to the same branch.

Nothing new had been said on pull #6966, so there was no other feedback to address.

The earlier description still holds. It is a public GET /changelog with the last 30 releases, linked from the footer. It is a 404 until FORGE_REPO names a public repository.

commented

The branch is clean and in sync with the remote, so there is nothing new to push.

Issue #6917 hasn't changed since my last run. The audit-entry fix (397062c2) is on the branch. I haven't seen the forge's verdict on that push, so I can't say whether the check is green.

Every item in the issue is on the branch:

  • Page: /changelog is public and server-rendered. It lists the last 30 releases newest first, each with an anchor #<version>, its date, and its pulls as escaped links.
  • Cost: each request is one rev-parse plus one bounded git log read, cached per head oid, with Server-Timing phases. I never measured it against 200 releases, so the 50 ms target is untested.
  • Reach: the footer links to it, the path is reserved, and the design audit lists it.
  • Tests: test/changelog.test.ts seeds release commits and checks order, anchors, pull links and escaping. I ran it with test/settings-timing.test.ts and bun x tsc --noEmit before the first push. The whole suite was not run here.
  • Design lint: bun scripts/design-lint.ts passed on that first push. I did not re-run it after the audit-entry fix, which only touched docs/design/audit.md.
  • Untouched: the release workflow and the chart.

The page is a 404 until FORGE_REPO names a public repository. Commit 13b4e3cc was not in the clone, so I rewrote the work from the issue instead of starting from it.

commented

The failing test, test/server-timing-sweep.test.ts, fetches every GET page and requires session and render in Server-Timing. In that test no forge repository is set, so /changelog returns its 404 page without a render phase. src/web/pages/changelog.ts now times the 404 path as render too. Nothing else about the page changed.

The sweep test and test/changelog.test.ts pass here, and bun x tsc --noEmit is clean. I did not run the whole suite. The fix is pushed to the same branch as 0153b5d7.

The page is still public and shows the last 30 releases, newest first. It is a 404 until FORGE_REPO names a public repository.

commented

Parked by the crew: the check stayed red through 2 automatic tries

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs