864a725 · accaa65 · c25f1e7
@@ -14,6 +14,7 @@
 */
import { readdirSync, readFileSync, writeFileSync } from "node:fs";
import { join } from "node:path";
import { byName } from "../src/http/mcp/shared.ts";
const ROOT = join(import.meta.dir, "..");
const DIR = join(ROOT, "src/http/mcp/tools");
@@ -44,7 +45,7 @@
type Documented = { readonly name: string; readonly doc?: string; readonly write
export function tableText(tools: readonly Documented[]): string {
  const rows = [...tools]
    .filter((t) => t.doc !== undefined)
      
        sentinelcrew
        17d ago
        outdated
      
      No test pins this order. Add a tableText case with mixed case (b, B, a → B, a, b) that fails under localeCompare. Share this comparator with src/http/mcp/tools.ts and don't write it twice.
    
    .sort((a, b) => a.name.localeCompare(b.name))
    .sort(byName)
    .map((t) => `| \`${t.name}\` | ${t.doc} | ${t.writes ? "yes" : ""} |`);
  return [BEGIN, "", "| tool | does | writes |", "| ---- | ---- | ------ |", ...rows, "", END].join("\n");
}
@@ -227,3 +227,7 @@
export function boardFailed(e: BoardError): Answer {
  if (typeof e === "object") return bad("refused", e.refused);
  return bad(e, BOARD_NOT_SAVED);
}
/** Orders by name's code points, never the machine's locale: the tool list and its docs table read the same everywhere. */
export const byName = (a: { readonly name: string }, b: { readonly name: string }): number =>
  a.name < b.name ? -1 : a.name > b.name ? 1 : 0;
@@ -3,7 +3,7 @@
 * gathered by the generated `tools/index.ts` (`bun scripts/mcp-tools.ts`).
 * A new tool is a new file there, so pulls adding tools do not collide (#5924).
 */
import type { Tool } from "./shared.ts";
import { byName, type Tool } from "./shared.ts";
import * as each from "./tools/index.ts";
export const TOOLS: readonly Tool[] = Object.values(each).sort((a, b) => a.name.localeCompare(b.name));
export const TOOLS: readonly Tool[] = Object.values(each).sort(byName);
      
        sentinelcrew
        17d ago
        outdated
      
      This is the same inline comparator as in scripts/mcp-tools.ts. Use one exported byName in both places, and add a test that TOOLS is sorted by code point.
    
@@ -50,6 +50,17 @@
describe("the gathered tools", () => {
    expect(md).toBe(withTable(md, tableText([...TOOLS, REPORT_TOOL])));
  });
  test("are ordered by code point, not the machine's locale", () => {
    const names = TOOLS.map((t) => t.name);
    expect(names).toEqual([...names].sort());
    const rows = tableText([
      { name: "b", doc: "x", writes: false },
      { name: "B", doc: "x", writes: false },
      { name: "a", doc: "x", writes: false },
    ]).split("\n").filter((l) => l.startsWith("| `"));
    expect(rows.map((l) => l.split("`")[1])).toEqual(["B", "a", "b"]);
  });
  test("a new file is one new line in the index, touching no other", () => {
    const before = indexText(["a", "c"]).split("\n");
    const after = indexText(["a", "b", "c"]).split("\n");
		@@ -14,6 +14,7 @@
14	14	*/
15	15	import { readdirSync, readFileSync, writeFileSync } from "node:fs";
16	16	import { join } from "node:path";
	17	import { byName } from "../src/http/mcp/shared.ts";
17	18
18	19	const ROOT = join(import.meta.dir, "..");
19	20	const DIR = join(ROOT, "src/http/mcp/tools");
		@@ -44,7 +45,7 @@ type Documented = { readonly name: string; readonly doc?: string; readonly write
44	45	export function tableText(tools: readonly Documented[]): string {
45	46	const rows = [...tools]
46	47	.filter((t) => t.doc !== undefined)
		sentinelcrew 17d ago outdated No test pins this order. Add a `tableText` case with mixed case (`b`, `B`, `a` → `B`, `a`, `b`) that fails under `localeCompare`. Share this comparator with `src/http/mcp/tools.ts` and don't write it twice.
47		.sort((a, b) => a.name.localeCompare(b.name))
	48	.sort(byName)
48	49	.map((t) => `\| \`${t.name}\` \| ${t.doc} \| ${t.writes ? "yes" : ""} \|`);
49	50	return [BEGIN, "", "\| tool \| does \| writes \|", "\| ---- \| ---- \| ------ \|", ...rows, "", END].join("\n");
50	51	}
		@@ -227,3 +227,7 @@ export function boardFailed(e: BoardError): Answer {
227	227	if (typeof e === "object") return bad("refused", e.refused);
228	228	return bad(e, BOARD_NOT_SAVED);
229	229	}
	230
	231	/** Orders by name's code points, never the machine's locale: the tool list and its docs table read the same everywhere. */
	232	export const byName = (a: { readonly name: string }, b: { readonly name: string }): number =>
	233	a.name < b.name ? -1 : a.name > b.name ? 1 : 0;
		@@ -3,7 +3,7 @@
3	3	* gathered by the generated `tools/index.ts` (`bun scripts/mcp-tools.ts`).
4	4	* A new tool is a new file there, so pulls adding tools do not collide (#5924).
5	5	*/
6		import type { Tool } from "./shared.ts";
	6	import { byName, type Tool } from "./shared.ts";
7	7	import * as each from "./tools/index.ts";
8	8
9		export const TOOLS: readonly Tool[] = Object.values(each).sort((a, b) => a.name.localeCompare(b.name));
	9	export const TOOLS: readonly Tool[] = Object.values(each).sort(byName);
		sentinelcrew 17d ago outdated This is the same inline comparator as in scripts/mcp-tools.ts. Use one exported `byName` in both places, and add a test that `TOOLS` is sorted by code point.
		@@ -50,6 +50,17 @@ describe("the gathered tools", () => {
50	50	expect(md).toBe(withTable(md, tableText([...TOOLS, REPORT_TOOL])));
51	51	});
52	52
	53	test("are ordered by code point, not the machine's locale", () => {
	54	const names = TOOLS.map((t) => t.name);
	55	expect(names).toEqual([...names].sort());
	56	const rows = tableText([
	57	{ name: "b", doc: "x", writes: false },
	58	{ name: "B", doc: "x", writes: false },
	59	{ name: "a", doc: "x", writes: false },
	60	]).split("\n").filter((l) => l.startsWith("\| `"));
	61	expect(rows.map((l) => l.split("`")[1])).toEqual(["B", "a", "b"]);
	62	});
	63
53	64	test("a new file is one new line in the index, touching no other", () => {
54	65	const before = indexText(["a", "c"]).split("\n");
55	66	const after = indexText(["a", "b", "c"]).split("\n");