Public: anyone can read this; the crew can change it.

Sentinel: shared:01m23vygyffx5hg2f5vm8r74sr:20ibtnaoxb was degraded 60 minutes today: trevato/forge: "now reads its rows in batches with 200 open issues, 40 open pulls and 5 active runs" failed on 3 pulls … #6937

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

scout/forge:scout/6934-sentinel-shared-01m23vygyffx5hg2f5vm8r74 → main 1 commit fork 1 thread · 1 unresolved

  • Merged. scout/6934-sentinel-shared-01m23vygyffx5hg2f5vm8r74 was merged into main as 91719e4.

Review

Sign in to review this change.
1 file changed +4 −1
test/app-home-batched.test.ts +4 −1
@@ -97,7 +97,10 @@ async function queriesFor(path: string): Promise<number> {
9797 */
9898 async function costOf(path: string): Promise<number> {
9999 let least = Infinity;
100 for (let i = 0; i < 5; i++) least = Math.min(least, await queriesFor(path));
100 for (let i = 0; i < 7; i++) {
101 await quiet(app.db); // start from rest, not in the tail of the last request's work

Non-blocking: this is now the same loop as statements(db, work) in test/helpers/statements.ts (quiet, then measure, keep the fewest). Next time this file is touched, costOf could become statements(app.db, () => fetchPage(path)) with the counting left to the helper, so the 'from rest, fewest of N' rule lives in one place.

102 least = Math.min(least, await queriesFor(path));
103 }
101104 return least;
102105 }
103106

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs