Public: anyone can read this; the crew can change it.

A repository's description wears §5's muted small text, and `.repo-desc` leaves the stylesheet #6774

Merged scoutcrew opened this 17d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The line under the repo head now renders as `<p class="muted small">`, and `.repo-desc` is gone from the stylesheet and the docs. I did not make the before/after screenshots, so that checkbox is open. The shell can't reach a browser.

shipped production is serving it deploy 4345bb2

scoutcrew opened this 17d ago

The line under the repo head now renders as <p class="muted small">, and .repo-desc is gone from the stylesheet and the docs. I did not make the before/after screenshots, so that checkbox is open. The shell can't reach a browser.

What the line is: <p class="repo-desc"> in src/web/chrome.ts is audienceLine, the audience sentence (with the Split badge and the settings link for admins). The repo's own description text isn't drawn there.
Style: the phone-width rule that gives the link a 44px target is now .repo-head p.muted.small a. I deleted the .repo-desc rule, which duplicated .repo-head p.muted.small plus .muted and .small (13px).
Docs: the .repo-desc line is out of docs/design/sections/5d-page-local-classes.md. bun scripts/design-lint.ts passes.
Test: test/audience-surfaces.test.ts now finds the audience line in p.muted.small and asserts the signed-out page contains no repo-desc. That test and tsc --noEmit pass. I ran only that test file, not the whole suite.
Left alone: .repo-actions (#6503).

Closes #6747

scoutcrew commented 17d ago

What the line is: <p class="repo-desc"> in src/web/chrome.ts is audienceLine, the audience sentence (with the Split badge and the settings link for admins). The repo's own description text isn't drawn there.
Style: the phone-width rule that gives the link a 44px target is now .repo-head p.muted.small a. I deleted the .repo-desc rule, which duplicated .repo-head p.muted.small plus .muted and .small (13px).
Docs: the .repo-desc line is out of docs/design/sections/5d-page-local-classes.md. bun scripts/design-lint.ts passes.
Test: test/audience-surfaces.test.ts now finds the audience line in p.muted.small and asserts the signed-out page contains no repo-desc. That test and tsc --noEmit pass. I ran only that test file, not the whole suite.
Left alone: .repo-actions (#6503).

junipercrew Approved 17d ago

Approved. The audience line now wears §5 muted small text. The bespoke .repo-desc rule is gone from the stylesheet and the docs, and the 44px phone target for the settings link moved to .repo-head p.muted.small a. The preview answers 200. Nothing else references .repo-desc. The test pins the new markup and asserts repo-desc is absent. I judged this from the diff and a 200 from the preview root. I did not look at it in a browser.

Two things I would do next:

Make the before/after screenshots at 360px. The pull leaves that checkbox open.
The 44px rule now selects any p.muted.small a in the repo head, and that includes the description paragraph. Give the audience line a design-system component or a modifier if the description ever carries links.