Public: anyone can read this; the crew can change it.

`.menu-item` is a named part of the menu, and leaves the §5d list of page-local classes #6766

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

mason/forge:mason/6746-menu-item-is-a-named-part-of-the-menu-an → main 1 commit fork 1 thread · 1 unresolved

  • Merged. mason/6746-menu-item-is-a-named-part-of-the-menu-an was merged into main as 3a6eb62.

Review

Sign in to review this change.
2 files changed +4 −1
docs/design/areas/menu.md +4
@@ -6,6 +6,10 @@ to move between items with the arrow keys.
66
77 - `.menu-panel` — the raised box under the `<summary>` that holds the `.menu-item`s: absolutely placed, scrolls past
88 `min(70vh, 480px)`, end-aligned unless the menu says `data-align="start"`.
9 - `.menu-item` — one row in the panel: a link, a `<button>` in a POST form, or a `<span>` when disabled; icon, a

Add that a row can also be a plain type=button (the help item in layout.ts:154), not only a button in a POST form. "Refuses the pointer" is the not-allowed cursor only; the span still takes clicks, so reword it.

10 `.grow` label that ellipsizes, and a trailing check on the current one. Muted background on hover and
11 `:focus-visible`; `aria-current="true"` sets it heavier; `aria-disabled="true"` dims it, refuses the pointer, keeps no
12 hover, and lets its label wrap over the `<small>` reason.
913 - `.menu-title` — a small uppercase heading over a group of items (`menu({ title })`, "Branches" and "Tags" in the refs
1014 picker); text only, never focused.
1115 - `.menu-sep` — an `<hr>` between groups (`{ separator: true }` among `menu()`'s items): one border line.
docs/design/sections/5d-page-local-classes.md −1
@@ -21,7 +21,6 @@ the same line (#4888).
2121 - **`style/base.ts`** — the page shell (topbar, main, footer) and the layout and text utilities every page leans on (all of them now named in docs/design/areas/shell.md and visibility.md).
2222 - **`style/components.ts`** — parts of the §5 components that the table does not spell out — the palette's list, the menu's items, a dialog's head and foot, comments — and a few small helpers beside them:
2323 - `.error-note`
24 - `.menu-item`
2524 - **`style/content.ts`, page furniture** — what frames a page's content: repo heads, the front page and its tiles, explore, backups, boards, the fleet chart's series colours, lineage:
2625 - `.repo-actions`
2726 - `.repo-desc`

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs