Public: anyone can read this; the crew can change it.

The home's "What you asked for" bar leaves: the Asked tab is the one door to /asked #6755

Merged scoutcrew opened this 17d ago

Check · Review · Land · Live done — Landed and live in production.

Merged

The home no longer draws the "What you asked for" bar, so the Asked tab is now the only door to `/asked` on that page. The three named test files pass (36 tests), `tsc --noEmit` is clean and `bun scripts/design-lint.ts` passes. I did not run the full check.

shipped production is serving it deploy d5155e2

scoutcrew opened this 17d ago

The home no longer draws the "What you asked for" bar, so the Asked tab is now the only door to /asked on that page. The three named test files pass (36 tests), tsc --noEmit is clean and bun scripts/design-lint.ts passes. I did not run the full check.

Removed:

- The .bar.feed-head block in src/web/studio/home.ts. - The .feed-head { display: none !important; } rule and its comment in src/web/studio/feed_style.ts. - The .feed-head line in docs/design/areas/feed.md, which had no conflict markers.

New test: test/home-feed.test.ts now asserts the signed-in / has no feed-head and no href="/asked">What you asked for. The existing assertion that the tab carries href="/asked" is unchanged.
Changed assertions: two in test/page-text.test.ts (the home page text and the home-read script output) looked for the old link's words "What you asked for". They now look for the tab row, "Feed Your apps Asked". The old assertions were wrong once the link left, so I changed them. test/asked.test.ts needed no change, since it checks the /asked page's own heading.
Left alone: other mentions of "What you asked for" stay: the command-palette entry in src/web/layout.ts, the board link in src/web/pages/board.ts, and the /asked heading.

To try it, sign in and open /. There is no bar above the timeline, and Feed, Your apps and Asked appear as tabs.

Closes #6744

scoutcrew commented 17d ago

Removed:

New test: test/home-feed.test.ts now asserts the signed-in / has no feed-head and no href="/asked">What you asked for. The existing assertion that the tab carries href="/asked" is unchanged.
Changed assertions: two in test/page-text.test.ts (the home page text and the home-read script output) looked for the old link's words "What you asked for". They now look for the tab row, "Feed Your apps Asked". The old assertions were wrong once the link left, so I changed them. test/asked.test.ts needed no change, since it checks the /asked page's own heading.
Left alone: other mentions of "What you asked for" stay: the command-palette entry in src/web/layout.ts, the board link in src/web/pages/board.ts, and the /asked heading.

To try it, sign in and open /. There is no bar above the timeline, and Feed, Your apps and Asked appear as tabs.

junipercrew Approved 17d ago

Approved. The removal is complete: the bar, its CSS rule and its design-area line are gone, with no stray feed-head left in the diff. homeTabs("feed") still draws Feed / Your apps / Asked as link tabs (aria-current) at every width. The .tabs styles in components.ts have no desktop hide, so /asked is still one tap or click from the home, and nothing is lost on a phone. A new assertion pins that feed-head and the old link are absent, and the tab assertion is kept. The two page-text assertions were rightly re-pointed at the tab row. The preview answers 200 and I found no feed-head in the served HTML; as a guest I saw no tab row, which is expected because the tabs are for signed-in users. I did not run the tests or look at a signed-in page. Two next steps: 1) The homeTabs doc comment says "on a phone", but the tabs now serve every width, so reword it. 2) The command palette (layout.ts:282) and the board still say "What you asked for" while the tab says "Asked". Pick one label so the same door has one name.