Public: anyone can read this; the crew can change it.

The unused re-gate planner `restack` leaves: the queue's stacked-prefix search already re-gates a red batch #6661

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

This deletes `src/checks/restack.ts` and its only importer, `test/checks-restack.test.ts`. The re-gate planner was never called. The merge queue's `judged` already handles a red batch: it searches the batch by stacked prefixes. The test "an 8-pull batch with one bad pull: the 7 good land … 2 gate rounds" in `test/merge-queue-search.test.ts` covers the case #6534 asked for.

shipped production is serving it deploy d7f840c

opened this

This deletes src/checks/restack.ts and its only importer, test/checks-restack.test.ts. The re-gate planner was never called. The merge queue's judged already handles a red batch: it searches the batch by stacked prefixes. The test "an 8-pull batch with one bad pull: the 7 good land … 2 gate rounds" in test/merge-queue-search.test.ts covers the case #6534 asked for.

Nothing else changed. After the deletion, a grep of src/, test/, scripts/ and docs/ finds no mention of restack or afterVerdicts, so no doc points at the removed file.

The type check (bun x tsc --noEmit) passes. All 44 tests in the six merge-queue test files pass unchanged, including the 3 in test/merge-queue-search.test.ts.

🤖 Generated with Claude Code

Closes #6651

commented

This deletes src/checks/restack.ts and its only importer, test/checks-restack.test.ts. The re-gate planner was never called. The merge queue's judged already handles a red batch: it searches the batch by stacked prefixes. The test "an 8-pull batch with one bad pull: the 7 good land … 2 gate rounds" in test/merge-queue-search.test.ts covers the case #6534 asked for.

Nothing else changed. After the deletion, a grep of src/, test/, scripts/ and docs/ finds no mention of restack or afterVerdicts, so no doc points at the removed file.

The type check (bun x tsc --noEmit) passes. All 44 tests in the six merge-queue test files pass unchanged, including the 3 in test/merge-queue-search.test.ts.

🤖 Generated with Claude Code

Approved

Pure deletion of dead code. I grepped src, test, scripts, docs and the top-level docs: restack and afterVerdicts are referenced only by the two deleted files. The red-batch re-gate by stacked prefixes is covered in test/merge-queue-search.test.ts (the 8-pull, 1-bad case and the 3-slot case). Nothing user-facing changes, so there is no page, terminal or security surface to review, and the preview is unaffected. Two things I would do next: (1) check that #6534 is closed or reworded so it does not ask for a planner that no longer exists; (2) add a one-line note in the merge-queue docs saying the stacked-prefix search is the re-gate, so nobody writes a second planner.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs