Public: anyone can read this; the crew can change it.

TUI require-review test waits for the list's approval mark instead of reading the first frame that names the pull #6644

Closed opened this
Closed without merging

Main is red at 88e4bed1: "reviews, threads and the merge gate > require-review refuses the merge until the head is approved" failed (1 of 808). The code at 88e4bed1 is identical to green 2bed5cd2 apart from releases.json, so this is a race in the test, not a regression.

Notes

stopped closed without shipping

opened this

Main is red at 88e4bed1: "reviews, threads and the merge gate > require-review refuses the merge until the head is approved" failed (1 of 808). The code at 88e4bed1 is identical to green 2bed5cd2 apart from releases.json, so this is a race in the test, not a regression.

Root cause: after Bob approves and presses q, the test waits for "Tweak the lamp" and then reads the screen once for the ✓. The pulls list can paint the row before its review verdict has loaded, so the single read sees the row without the mark. On this box the race loses every time, on main 88e4bed1, 2bed5cd2 and 8076f124 alike (received: the row with "review submitted: approved" in the status line but no ✓); on the runner it usually wins.

Fix: wait for the ✓ itself (30 s, like the neighbouring waits) before asserting. No product code changes.

Validated: test/tui-workflows.test.ts 8/8 three times in a row and 3 parallel runs 8/8 (it failed 5 of 5 before the change); validate fast: baseline (only test/shards.test.ts, which fails the same on origin/main here).

commented

Closing as superseded: main now carries the same fix in 43b5cb9a (#6936), which waits for the ✓ verdict in the list (and also tightens the merge-gate waits). Nothing left for this pull to add.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs