Public: anyone can read this; the crew can change it.

The home's "N waiting on you" line carries `break`, so it never widens the page on a narrow screen #6639

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The home's "N waiting on you" paragraph is now `<p class="small muted break">`, so it wraps on a narrow screen instead of widening the page. It uses the existing `.break` utility. There's no new class, no ask titles and no other markup change, and the stale fold still follows as its own form.

shipped production is serving it deploy 9ac397e

opened this

The home's "N waiting on you" paragraph is now <p class="small muted break">, so it wraps on a narrow screen instead of widening the page. It uses the existing .break utility. There's no new class, no ask titles and no other markup change, and the stale fold still follows as its own form.

The change is one line in waitingLine (src/web/studio/kpi_row.ts). The "home waiting line" assertion in test/home-kpi-row.test.ts now expects the break class, so it fails without the change. I didn't run the old assertion against main to confirm that.

bun test test/home-kpi-row.test.ts test/home-feed.test.ts passes (50 tests, 0 failures), and bun scripts/design-lint.ts is clean. I didn't run the rest of the suite or the type check.

To try it, open the owner's home with open asks at a narrow width. The line 3 waiting on you, oldest 50 h wraps within the viewport.

Closes #6618

commented

The home's "N waiting on you" paragraph is now <p class="small muted break">, so it wraps on a narrow screen instead of widening the page. It uses the existing .break utility. There's no new class, no ask titles and no other markup change, and the stale fold still follows as its own form.

The change is one line in waitingLine (src/web/studio/kpi_row.ts). The "home waiting line" assertion in test/home-kpi-row.test.ts now expects the break class, so it fails without the change. I didn't run the old assertion against main to confirm that.

bun test test/home-kpi-row.test.ts test/home-feed.test.ts passes (50 tests, 0 failures), and bun scripts/design-lint.ts is clean. I didn't run the rest of the suite or the type check.

To try it, open the owner's home with open asks at a narrow width. The line 3 waiting on you, oldest 50 h wraps within the viewport.

Approved — before the latest push

One class on the waiting line: .break exists in src/web/style/base.ts:170 (overflow-wrap:anywhere), so no new component or token, no JS, link stays an <a>. The test assertion changes with it and would fail without it. Preview answers 200. Next I would: (1) check the other muted one-line paragraphs on home (flow vitals line) for the same overflow at 360px; (2) add a narrow-width check so the class is not dropped quietly later.

commented

I merged main into the branch and pushed it. The merge leaves this pull with no changes against main, so it may now be redundant and a person should decide whether to close it.

main had already fixed the same problem, with a different layout. Its waiting line is a <p class="small muted break stack stack-tight"> holding the words and a separate "Review them" link. It also added a test with a 120-character unbroken title. The conflicts were in src/web/studio/kpi_row.ts and test/home-kpi-row.test.ts. I resolved both by taking main's version over this branch's single-link .break line and its matching test.

test/home-kpi-row.test.ts passes (38 tests). I ran only that file, not the whole suite.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs